WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#28987 closed defect (bug) (fixed)

doubled "Customize" button

Reported by: afercia Owned by: SergeyBiryukov
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Themes Keywords: has-patch commit
Focuses: administration Cc:
PR Number:

Description

After 29026 that adds a "return" argument to the customize.php link in the menu, now if you click on an activated theme details you see two "Customize" buttons. See attached screenshot.
In themes.php, "$current_theme_actions" skips a menu item equal to "customize.php" which of course is now different and is "customize.php?return...etc..."

Attachments (3)

doubled-customize-button.png (356.2 KB) - added by afercia 5 years ago.
28987.patch (742 bytes) - added by afercia 5 years ago.
28987.2.patch (743 bytes) - added by afercia 5 years ago.

Download all attachments as: .zip

Change History (9)

@afercia
5 years ago

#1 @afercia
5 years ago

  • Keywords has-patch added

#2 @ocean90
5 years ago

  • Focuses administration added
  • Milestone changed from Awaiting Review to 4.0

#3 follow-up: @obenland
5 years ago

Nice find afercia!

Would you mind refreshing the patch and adding another whitespace between the 'customize.php' string and the closing bracket of strpos()? It should be good to go then.

Thanks!

#4 in reply to: ↑ 3 @afercia
5 years ago

Replying to obenland:

Nice find afercia!

hi Konstantin, thx.

Would you mind refreshing the patch...

Sure, there you go

@afercia
5 years ago

#5 @obenland
5 years ago

  • Keywords commit added

Thanks!

#6 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29324:

Fix duplicate Customize button in theme details modal.

props afercia.
fixes #28987.

Note: See TracTickets for help on using tickets.