Unit tests for dbDelta()

[jdgrimes]

The dbDelta() function is kind of a mess, and also very buggy. There are several open tickets seeking to improve it:

#10404
#28591
#20634
#20263
#14445

...

Let's pave the way for them by adding some basic unit tests for the function, which can be expanded to test the enhancements/bugfixes.

[jdgrimes]

Initial tests

[jdgrimes]

29020.diff​ is a first pass. Once applied, run

$ phpunit tests/phpunit/tests/admin/functions/dbdelta.php
Installing...
Running as single site... To run multisite, use -c tests/phpunit/multisite.xml
Not running ajax tests... To execute these, use --group ajax.
PHPUnit 3.7.28 by Sebastian Bergmann.

Configuration read from /Users/johngrimes/svn/wordpress/trunk/phpunit.xml.dist

..S....

Time: 10.83 seconds, Memory: 24.50Mb

OK, but incomplete or skipped tests!
Tests: 7, Assertions: 10, Skipped: 1.

Skipped test is for backticks, related to #20263.

[nacin]

Awesome, thanks! Let's toss the tests for #20263 into that ticket, rather than committing them now. (Now that we have a merged repo, they should be committed with the code to fix it.)

The best place for these tests is likely tests/phpunit/tests/db/dbDelta.php, class name Tests_DB_dbDelta. (Alternatively, tests/phpunit/tests/admin/includesUpgrade.php, class Tests_Admin_includesUpgrade.)

[jdgrimes]

Replying to nacin:

Awesome, thanks! Let's toss the tests for #20263 into that ticket, rather than committing them now. (Now that we have a merged repo, they should be committed with the code to fix it.)

The best place for these tests is likely tests/phpunit/tests/db/dbDelta.php, class name Tests_DB_dbDelta. (Alternatively, tests/phpunit/tests/admin/includesUpgrade.php, class Tests_Admin_includesUpgrade.)

29020.2.diff​ moves the tests to tests/phpunit/tests/db/dbDelta.php, changes the class name, and removes the tests for #20263.

[DrewAPicture]

29020.2.diff​ still applies.

[jorbin]

20920.2.diff looks like some good tests that are all currently passing.

I would like to see this combined with the tests added in [32108], likely by making those tests better (using the setup and teardown functions here for example ).

@pento - any thoughts on these tests?

[pento]

29020.2.diff​ is a good start.

I suspect dbDelta() unit tests will be an ongoing effort, much like unit tests for wpautop(). As we discover more edge cases, add more unit tests.

[salcode]

Merges patch 29020.2.diff changes into existing tests file

Patch created at WordCamp Philly 2015
@tryon
@jtsternberg
@ebinnion
@JPry
@avnarun
@kevkoeh
@jorbin
@salcode

[jorbin]

In 32770:

Improve dbDelta unit tests

Add new tests for more parts of dbDelta. This was cleaned up and prepared for commit at #wcphilly contributor day.

Props jdgrimes, tryon, jtsternberg, ebinnion, JPry, avnarun, kevkoeh, jorbin, salcode.
Fixes #29020.

[tryon]

Insert test

[tryon]

Added 'Insert Into' test for dbdelta

Patch created at WordCamp Philly 2015

[obenland]

@jorbin, can you check on that additional patch and commit/close when you get a chance?

[jorbin]

In 33175:

Add dbDelta insert test

Test to make sure that dbDelta properly inserts a value into the DB.

Props tryon, jtsternberg, ebinnion, JPry, avnarun, kevkoeh, salcode.
Fixes #29020.