Opened 10 years ago
Closed 10 years ago
#29037 closed defect (bug) (fixed)
Media Grid: Doesn't display upload errors
Reported by: | danielbachhuber | Owned by: | wonderboymusic |
---|---|---|---|
Milestone: | 4.0 | Priority: | normal |
Severity: | major | Version: | 4.0 |
Component: | Media | Keywords: | ui-feedback has-patch |
Focuses: | ui | Cc: |
Description
The media library has been giving me trouble in my local install. When I try to upload an image outside Media Grid, I get the cryptic "HTTP error". When I try to upload an image within the Media Grid, the error never appears.
After a cursory look, it doesn't appear Media Grid has any error handling.
Attachments (1)
Change History (10)
#2
@
10 years ago
After uploading with "browser uploader" outputs no error message.
The URL contains message=3
and it disappears, watch https://youtu.be/JZBB4TNFwPE
Would like to patch, but really don't know how to approach. Found some error outputting code in /wp-admin/includes/media.php#L1727 & L1931
I think that param in the URL should work with /wp-includes/js/media-views.js#L3875 code, but don't have a clue right now how to fix.
#4
@
10 years ago
Tried it, on successful upload it adds Attachment Details http://i.imgur.com/jLGz1GI.png & https://youtu.be/wSmBC9OPE6g
Could we skip outputting on success ?
Errors could look like on /wp-admin/media-new.php page, under the uploader block http://i.imgur.com/1iBhlco.png ?
#5
follow-up:
↓ 7
@
10 years ago
- Focuses ui added
- Keywords ui-feedback added; needs-patch removed
So, this works, perhaps needs design input
#6
@
10 years ago
- Keywords needs-patch added
- Version set to trunk
From #29141 by celloexpressions:
There are issues with uploading multiple invalid files - every other one shows the attachment details sidebar and then hides the whole sidebar.
#7
in reply to:
↑ 5
@
10 years ago
Replying to wonderboymusic:
So, this works, perhaps needs design input
Let's finish up the JS here (the issue ocean90 mentioned above - I triggered it by uploading multiple invalid filetypes in a row) and do the CSS on #29141 (has a preliminary patch).
ticket:28851:14