function current_time( $type, $gmt = 0 ) don't return GMT if 'Y-m-d H:i:s' is pass as type

[pbearne]

Hi Guys

Have been trying to write unit tests for the function current_time() in the functions.php

It works OK if the server/php timezone is GMT but if I run date_default_timezone_set('America/Los_Angeles'); and change the timezone it fails to pass the unit tests

So here are the unit tests and patch that seems to fix it.

It needs better eyes than mine to check this :-) as this a core function

Paul

[pbearne]

unit test and patch for current time()

[SergeyBiryukov]

Related: #20973, #23384, #25002, #25331, #25365, #25555, #25768, #28636, ​IRC chat.

[pbearne]

hope the unit tests help

[chriscct7]

Patch still applies. Needs review.

[pbearne]

Replying to chriscct7:

Patch still applies. Needs review.

Ping me if we need to change anything to get this in

Paul

[marco.marsala]

See #38940

[Rarst]

Duplicate of #40653.

Folding this into a general rewrite of the function.