WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#29087 closed defect (bug) (fixed)

Compacting non-existant variables in WP_Upgrader::install_package()

Reported by: jdgrimes Owned by: dd32
Milestone: 4.2 Priority: normal
Severity: normal Version: 2.8
Component: Upgrade/Install Keywords: has-patch
Focuses: Cc:

Description

WP_Upgrader::install_package() calls compact() with a list of variables, some of which have never existed since this code was added in [11005]. This doesn't cause any problems, as non-existent variables are silently ignored by compact(), but it is quite confusing (I don't know what performance implications might be, but that is trivial anyway).

The following variables don't exist:

  • 'local_source'
  • 'source_name'
  • 'delete_source_dir'

Attachments (1)

29087.diff (742 bytes) - added by jdgrimes 7 years ago.

Download all attachments as: .zip

Change History (4)

@jdgrimes
7 years ago

#1 @jdgrimes
7 years ago

  • Keywords has-patch added

#2 @dd32
7 years ago

  • Milestone changed from Awaiting Review to 4.2

#3 @dd32
7 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 31327:

WP_Upgrader: Remove references to non-existant variables that have never existed.
Props jdgrimes. Fixes #29087

Note: See TracTickets for help on using tickets.