WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 4 years ago

#29121 closed defect (bug) (fixed)

Esc does not dismiss the Attachment Details modal after visiting Edit Image

Reported by: ryan's profile ryan Owned by: wonderboymusic's profile wonderboymusic
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Media Keywords:
Focuses: Cc:

Description

Visit the media gallery in grid view. Click an image to bring up the Attachment Details modal. Hit Esc to dismiss the modal. Now, bring up the modal again and click Edit Image. Esc no longer dismisses the modal. Click Cancel to go back to the attachment details modal. Esc still does not dismiss the modal.

Change History (7)

This ticket was mentioned in IRC in #wordpress-dev by rboren. ​View the logs.
11 years ago

#2 @wonderboymusic
11 years ago

In 29443:

Media Grid: remove Router code that doesn't actually ever run.

See #29121.

#3 @wonderboymusic
11 years ago

In 29444:

Media Grid: remove Router code that doesn't actually ever run.

See #29121.

#4 @wonderboymusic
11 years ago

window.imageEdit is pretty burly. The escape keypress is getting hijacked until the content is clicked once/focused, then it works. Awesome.

#5 @wonderboymusic
11 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 29481:

In the Edit Attachment frame, when in Edit Image mode, add a key event for Escape. There are conflicting keydown handlers that don't propagate the event to the modal properly.

Fixes #29121.

#6 @ocean90
11 years ago

  • Component changed from Gallery to Media

This ticket was mentioned in ​Slack in #core-editor by dd32. ​View the logs.
4 years ago

Note: See TracTickets for help on using tickets.