WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#2914 closed enhancement (fixed)

Replace die('s with wp_die('s

Reported by: filosofo Owned by: filosofo
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.1
Component: Administration Keywords: bg|has-patch
Focuses: Cc:

Description

Latest revision; excluded ajax and wp-blog-header, as well as a few empty die()'s.

Attachments (1)

wp_dies.diff (41.3 KB) - added by filosofo 9 years ago.

Download all attachments as: .zip

Change History (3)

@filosofo9 years ago

comment:1 @ryan9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3985]) Use wp_die(). Props filosofo. fixes #2914

comment:2 @ryan9 years ago

I had to make a few changes. Don't wp_die after a redirect. Don't wp_die when wp-config cannot be loaded. Don't wp_die when an importer is using die as a means of sending non error output. A good general rule is to only wp_die when there is a die with a translatable string in it.

I remove a few wp_dies from wp-login in the reset/retrieve password areas. We could add these back if we integrate the echos that come before the die into the die.

Note: See TracTickets for help on using tickets.