WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#29141 closed defect (bug) (fixed)

Media Grid: error-message sidebar covers grid

Reported by: Ipstenu Owned by: helen
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Media Keywords: needs-patch
Focuses: ui Cc:

Description

https://cloudup.com/iH1BeOXpJBM

Possibly related to #29085

This occurs in portrait and landscape, on iOS and android as well.

Attachments (6)

29141.png (103.9 KB) - added by celloexpressions 7 years ago.
Proposed design. This is a starting point, could use some more work from a designer, exact alignment is pending the removal of the checkboxes.
29141.diff (1.2 KB) - added by celloexpressions 7 years ago.
Screen Shot 2014-08-21 at 1.04.55 AM.png (327.5 KB) - added by helen 7 years ago.
Screen Shot 2014-08-21 at 1.08.40 AM.png (288.6 KB) - added by helen 7 years ago.
29141.2.diff (1.5 KB) - added by stephdau 7 years ago.
Props pento for JS
Screen Shot 2014-08-25 at 22.57.26.png (1.1 MB) - added by stephdau 7 years ago.

Download all attachments as: .zip

Change History (22)

This ticket was mentioned in IRC in #wordpress-dev by celloexpressions. View the logs.


7 years ago

#2 @celloexpressions
7 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Per IRC, can't reproduce anymore and that sidebar doesn't exist.

#3 @celloexpressions
7 years ago

  • Focuses ui added
  • Keywords needs-patch added
  • Milestone set to 4.0
  • Summary changed from Media Grid: on tablet 'sidebar area' covers images to Media Grid: error-message sidebar covers grid

This is an issue; specifically, the sidebar is only used for displaying upload errors. Rather than a sidebar, it should probably be displayed as more of a popup, with more visual dismiss-ability. That way only a minimal amount of attachments are covered by it.

I'm working on a patch.

@celloexpressions
7 years ago

Proposed design. This is a starting point, could use some more work from a designer, exact alignment is pending the removal of the checkboxes.

#4 follow-up: @celloexpressions
7 years ago

  • Keywords has-patch added; needs-patch removed
  • Resolution invalid deleted
  • Status changed from closed to reopened

29141.diff is a start. There are issues with uploading multiple invalid files - every other one shows the attachment details sidebar and then hides the whole sidebar. That's most likely related to the JS though, and should probably be fixed elsewhere.

#5 in reply to: ↑ 4 @ocean90
7 years ago

Replying to celloexpressions:

There are issues with uploading multiple invalid files - every other one shows the attachment details sidebar and then hides the whole sidebar.

See #29037.

#6 @wonderboymusic
7 years ago

In 29526:

Media Grid: improve the design of upload errors.

Props celloexpressions.
See #29141.

#7 @adamsilverstein
7 years ago

looks good! one thing: at certain screen sizes, i'm seeing the error 'behind' the search bar:

http://cl.ly/image/3h3Q2z0l3b2K/%2329141%20(Media%20Grid%3A%20error-message%20sidebar%20covers%20grid)%20%E2%80%93%20WordPress%20Trac%202014-08-18%2016-41-13%202014-08-18%2016-41-16.jpg

#8 @helen
7 years ago

  • Keywords needs-patch added; has-patch removed

I think I'd rather see these full width between the grid and the filter bar, and just push down/up the grid when needed. I don't think that movement is a big deal, given that you probably want to see it and it's dismissable.

#9 @ocean90
7 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from reopened to closed

In 29548:

Media Grid: Don't hide error messages behind the toolbar.

fixes #29141.

#10 @ocean90
7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Missed helen's comment.

#11 @helen
7 years ago

Screenshots above are the result of some tinkering - it required that the .media-sidebar div be moved, though. The first has the issue of the close icon looking like it dismisses just the one error but it really dismisses all of them. Individual errors are less clear in the second. Just wanted to drop that here sooner than later for feedback.

#12 @helen
7 years ago

  • Owner changed from ocean90 to helen
  • Status changed from reopened to accepted

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.


7 years ago

@stephdau
7 years ago

Props pento for JS

#14 @stephdau
7 years ago

attachment:29141.2.diff figures out the moving of the media-sidebar div to underneath the media-toolbar div (props pento), and begins to style it relatively, coming closer to Helen's 2nd screenshot.

The change does not affect the errors in other upload UIs: https://cloudup.com/cHqxorvI5Sz

This ticket was mentioned in IRC in #wordpress-dev by stephdau. View the logs.


7 years ago

#16 @helen
7 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 29612:

Media Grid: Show upload errors above the grid rather than as a popup.

props pento, stephdau, helen. fixes #29141.

Note: See TracTickets for help on using tickets.