Opened 9 years ago
Closed 9 years ago
#29141 closed defect (bug) (fixed)
Media Grid: error-message sidebar covers grid
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.0 | Priority: | normal |
Severity: | normal | Version: | 4.0 |
Component: | Media | Keywords: | needs-patch |
Focuses: | ui | Cc: |
Description
https://cloudup.com/iH1BeOXpJBM
Possibly related to #29085
This occurs in portrait and landscape, on iOS and android as well.
Attachments (6)
Change History (22)
This ticket was mentioned in IRC in #wordpress-dev by celloexpressions. View the logs.
9 years ago
#2
@
9 years ago
- Milestone Awaiting Review deleted
- Resolution set to invalid
- Status changed from new to closed
#3
@
9 years ago
- Focuses ui added
- Keywords needs-patch added
- Milestone set to 4.0
- Summary changed from Media Grid: on tablet 'sidebar area' covers images to Media Grid: error-message sidebar covers grid
This is an issue; specifically, the sidebar is only used for displaying upload errors. Rather than a sidebar, it should probably be displayed as more of a popup, with more visual dismiss-ability. That way only a minimal amount of attachments are covered by it.
I'm working on a patch.
@
9 years ago
Proposed design. This is a starting point, could use some more work from a designer, exact alignment is pending the removal of the checkboxes.
#4
follow-up:
↓ 5
@
9 years ago
- Keywords has-patch added; needs-patch removed
- Resolution invalid deleted
- Status changed from closed to reopened
29141.diff is a start. There are issues with uploading multiple invalid files - every other one shows the attachment details sidebar and then hides the whole sidebar. That's most likely related to the JS though, and should probably be fixed elsewhere.
#5
in reply to:
↑ 4
@
9 years ago
Replying to celloexpressions:
There are issues with uploading multiple invalid files - every other one shows the attachment details sidebar and then hides the whole sidebar.
See #29037.
#8
@
9 years ago
- Keywords needs-patch added; has-patch removed
I think I'd rather see these full width between the grid and the filter bar, and just push down/up the grid when needed. I don't think that movement is a big deal, given that you probably want to see it and it's dismissable.
#9
@
9 years ago
- Owner set to ocean90
- Resolution set to fixed
- Status changed from reopened to closed
In 29548:
#10
@
9 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Missed helen's comment.
#11
@
9 years ago
Screenshots above are the result of some tinkering - it required that the .media-sidebar
div be moved, though. The first has the issue of the close icon looking like it dismisses just the one error but it really dismisses all of them. Individual errors are less clear in the second. Just wanted to drop that here sooner than later for feedback.
This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.
9 years ago
#14
@
9 years ago
attachment:29141.2.diff figures out the moving of the media-sidebar div to underneath the media-toolbar div (props pento), and begins to style it relatively, coming closer to Helen's 2nd screenshot.
The change does not affect the errors in other upload UIs: https://cloudup.com/cHqxorvI5Sz
Per IRC, can't reproduce anymore and that sidebar doesn't exist.