Wrong length (duration) in wp_read_video_metadata()

[jrf]

Ran into this when running some tests on uploaded video files.

The length_formatted value was correct, while the length was x 1000. Turned out to be correct in the original meta data, but wrongly overwritten by the tag data. This might be caused by a bug in getID3.

Issues can easily be reproduced using the attached example file.

Patch attached as well.

[jrf]

Patch file

[jrf]

Example file which will show the bug if uploaded

[wonderboymusic]

You are correct, it is getting clobbered. Also need to change ceil() to round() in wp_read_video_metadata() and wp_read_audio_metadata().

29176.diff​ does that.

[wonderboymusic]

In 29728:

Don't overwrite the length property unnecessarily when generating metadata for audio and video files.

Props jrf, wonderboymusic.
Fixes #29176.

[jrf]

I kind of had the feeling that the ceil() was on purpose as if they are round down, the video could be cut off just before the end.

[wonderboymusic]

length_formatted is set to the value of playtime_string, which is a prop returned by getID3::analyze() - it is the only value we ever read directly. length is just there in case you want to format your own time string. Without round(), the values can differ: length would be 46 while length_formatted would be 45. I vote for consistency with the values, since ceil() was already converting the float, there was no chance for the user to make that choice.