WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#29180 closed defect (bug) (fixed)

Conditional wrappers for styles exclude inline styles

Reported by: georgestephanis's profile georgestephanis Owned by: wonderboymusic's profile wonderboymusic
Milestone: 4.2 Priority: normal
Severity: normal Version: 3.9
Component: Script Loader Keywords: has-patch
Focuses: Cc:

Description

When adding inline styles to a conditional stylesheet, the inline css is outside of the conditional.

So if I have an IE only stylesheet, and add some styles to it, while the external asset is IE only, the attached inline styles aren't.

Certainly an edge case, but worth correcting for.

Unit tests provided.

Attachments (1)

conditionalize-inline-css-also.diff​ (2.6 KB) - added by georgestephanis 10 years ago.

Download all attachments as: .zip

Change History (6)

@georgestephanis
10 years ago

This ticket was mentioned in IRC in #wordpress-dev by georgestephanis. ​View the logs.
10 years ago

#3 @helen
10 years ago

  • Version changed from trunk to 3.9

I imagine this has happened since before 3.9, but getting it off the trunk report at least.

#4 @wonderboymusic
10 years ago

  • Milestone changed from Awaiting Review to 4.2

#5 @wonderboymusic
10 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 31031:

Ensure that inline styles attached to conditional stylesheets are also conditional.

Adds unit test.

Props georgestephanis.
Fixes #29180.

Note: See TracTickets for help on using tickets.