post/comment IN and NOT IN params for WP_Comment_Query

[boonebgorges]

WP_Comment_Query would be much more useful if it natively supported the following parameters: 'post_id__in', 'post_id__not_in', 'comment_id__in', 'comment_id__not_in'. (One possible use case: a plugin that hides certain comments based on user permissions.)

The attached patch is a simple implementation of these four parameters, with unit tests.

[wonderboymusic]

4.1

[DrewAPicture]

In looking at WP_Comment_Query::query() I notice that it's generally devoid of inline documentation. I'd at the very least prefer to see some single-line comments explaining what's being parsed for these four added arguments, as well as an @since 4.1.0 tag for the added arguments.

Looks like the default args aren't documented in here either, but we'll take care of that over in #28298.

[boonebgorges]

Replying to DrewAPicture:

In looking at WP_Comment_Query::query() I notice that it's generally devoid of inline documentation. I'd at the very least prefer to see some single-line comments explaining what's being parsed for these four added arguments, as well as an @since 4.1.0 tag for the added arguments.

Looks like the default args aren't documented in here either, but we'll take care of that over in #28298.

29189.2.patch adds inline comments, @since for the new params, and missing @ticket numbers for the tests.

[DrewAPicture]

The added docs in 29189.2.patch​ look great!

[boonebgorges]

See also #25386

[boonebgorges]

Forgot to hit this one too in the commit message. r29808