Twenty Fourteen: Featured_Content::hide_featured_term() triggers notice when using get_terms()

[dnaber-de]

Featured_Content::hide_featured_term(), which is a callback on the filter get_terms assumes that the first parameter is always an array of stdClass objects.

get_terms() provides the possibility to fetch only term IDs and so the filter pass an array as numeric values to the callback, which then causes the following error:

Notice: Trying to get property of non-object in /var/www/wp-content/themes/twentyfourteen/inc/featured-content.php on line 334

In fact, every possible value of the fields parameter besides all and count triggers this error.

The Following Plugin reproduces the Error, if at least one term of post_tag taxonomy exists:

<?php
/**
 * Plugin Name: Test
 */
add_filter( 'the_content', function( $content ) {

	$terms = get_terms(
		'post_tag',
		array(
			'hide_empty' => FALSE,
			'fields'     => 'ids'
		)
	);

	return $content;
} );

[dnaber-de]

Obviously a duplicate of #28072

[ocean90]

Duplicate of #28072.