#29197 closed enhancement (fixed)
WP_Customize_Panel should not extend WP_Customize_Section
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.0 | Priority: | high |
Severity: | normal | Version: | 4.0 |
Component: | Customize | Keywords: | has-patch |
Focuses: | Cc: |
Description
Continuing on from #28979 and #27406, we need to punt this from 4.0 as it's too involved to change now. As a result, we're temporarily marking WP_Customize_Panel
as final until we can implement it.
Full explanations of this are on #28979, but the gist is: Panels are not Sections (implied by the current implementation), Panels and Sections are both containers. Now that we have WP_Customize_Manager:containers() (used for mixed top-level section/panel sorting), we have containers, but not really. This change will allow us to open up WP_Customize_Panel to be extended like everything else in the Customizer can be.
Attachments (3)
Change History (9)
#1
@
11 years ago
- Keywords 4.1-early added
- Priority changed from normal to high
This needs to happen ASAP since we're closing off parts of the API until it happens.
#2
@
11 years ago
- Keywords needs-patch added; has-patch 4.1-early removed
- Milestone changed from Future Release to 4.0
- Summary changed from Introduce WP_Customize_Container, and have both WP_Customize_Panel and WP_Customize_Section extend it (rather than WP_Customize_Panel extending section) to WP_Customize_Panel should not extend WP_Customize_Section
Per today's dev chat, we're going to make WP_Customize_Panel and WP_Customize_Section totally distinct, in 4.0, per nacin. While they're both UI containers, and share a few common functions, they are distinct objects and the code duplication is similar to that in WP_Customize_Control (which has stuff similar to section).
I'm working on a patch.
Straight diff on
class-wp-customize-section.php
, which would then be renamed toclass-wp-customize-container.php
. Will probably need to be refreshed once we're ready to do this, and it should happen early since it'll invalidate all patches against this file.