Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#29226 closed defect (bug) (fixed)

Pinned Visual Editor breaking footer

Reported by: hardeepasrani's profile hardeepasrani Owned by:
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: TinyMCE Keywords: has-patch
Focuses: Cc:


In addition to #29225, here's another bug with a lot of text in text editor of 4.0's floating TinyMCE.

Just like #29225, paste a lot of text into the text editor and scroll down to the bottom.

When you'll toggle from text to visual editor, it will scroll to the top (because it's just some plain text without line breaks, so the visual editor will take it into a single line) and it will break down the bottom of the page, as seen in the attached image.

If you guys are having problems in understanding this ticket, then notify me so I could attach a video :)

Thanks for the amazing work :)

Attachments (2)

editor.png (81.8 KB) - added by hardeepasrani 10 years ago.
When you scroll to the bottom after toggling to the visual editor.
reset-client-window.29226.patch (520 bytes) - added by mackensen 10 years ago.
Resets scroll position if necessary

Download all attachments as: .zip

Change History (7)

10 years ago

When you scroll to the bottom after toggling to the visual editor.

#1 @johnbillion
10 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.0
  • Summary changed from Turning to Visual Editor breaking post editor screen in 4.0 to Pinned Visual Editor breaking footer

This is quite easy to reproduce. You can also edit a post which contains loads of content, scroll right to the bottom, then start deleting content from the bottom up. The footer of the site then starts to rise up.

#2 @iseulde
10 years ago

I also noticed that, when you're at the bottom and scroll a tiny bit further (possible on a mac at least), the position switches between fixed and absolute for an instant, which causes the sidebar to jump.

#3 @mackensen
10 years ago

I tested this with a 15-paragraph post (1501 words). On a 13" Macbook the size of #wpwrap was 1311px X 4552px in the visual editor but only 1311px X 2584px in the text editor. Essentially you're off the page and the design doesn't compensate. Changing the position property on #wpwrap from relative to fixed resolves the display issue but breaks scrolling.

10 years ago

Resets scroll position if necessary

#4 @mackensen
10 years ago

  • Keywords has-patch added; needs-patch removed

I've added attachment:reset-client-window.29226.patch which resets the client scroll position if it exceeds the size of #wpwrap.

#5 @azaozz
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [29592]:

Editor scrolling: fix window height when switching Visual to Text and the editor is shorter. Props mackensen, fixes #29226.

Note: See TracTickets for help on using tickets.