WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#29254 closed defect (bug) (fixed)

PHP Notices when running makepot.php tool on a plugin

Reported by: jdgrimes Owned by: SergeyBiryukov
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

When I run ~/tools/i18n/makepot.php on a plugin, I get a bunch of strict notices (PHP 5.5).

PHP Strict Standards:  Only variables should be passed by reference in /Users/johngrimes/svn/wordpress/trunk/tools/i18n/extract.php on line 31
PHP Strict Standards:  Only variables should be passed by reference in /Users/johngrimes/svn/wordpress/trunk/tools/i18n/extract.php on line 34
PHP Strict Standards:  Non-static method MakePOT::get_first_lines() should not be called statically, assuming $this from incompatible context in /Users/johngrimes/svn/wordpress/trunk/tools/i18n/pot-ext-meta.php on line 35
PHP Strict Standards:  Non-static method MakePOT::get_addon_header() should not be called statically, assuming $this from incompatible context in /Users/johngrimes/svn/wordpress/trunk/tools/i18n/pot-ext-meta.php on line 38
PHP Strict Standards:  Non-static method PO::export_entry() should not be called statically, assuming $this from incompatible context in /Users/johngrimes/svn/wordpress/trunk/tools/i18n/pot-ext-meta.php on line 45
PHP Strict Standards:  Non-static method PO::comment_block() should not be called statically, assuming $this from incompatible context in /Users/johngrimes/svn/wordpress/trunk/src/wp-includes/pomo/po.php on line 200
PHP Strict Standards:  Non-static method PO::prepend_each_line() should not be called statically, assuming $this from incompatible context in /Users/johngrimes/svn/wordpress/trunk/src/wp-includes/pomo/po.php on line 185
PHP Strict Standards:  Non-static method PO::poify() should not be called statically, assuming $this from incompatible context in /Users/johngrimes/svn/wordpress/trunk/src/wp-includes/pomo/po.php on line 204

Attachments (1)

makepot.diff (3.2 KB) - added by jdgrimes 5 years ago.

Download all attachments as: .zip

Change History (4)

@jdgrimes
5 years ago

#1 @jdgrimes
5 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29563:

Fix strict notices in makepot.

props jdgrimes.
fixes #29254.

#3 @SergeyBiryukov
5 years ago

  • Component changed from General to Build/Test Tools
  • Milestone changed from Awaiting Review to 4.0
Note: See TracTickets for help on using tickets.