Plural forms not available for some strings

[pavelevap]

There are several strings which do not allow specific plurals in Settings - Reading.

<?php _e( 'posts' ); ?>

<?php _e( 'items' ); ?>

It looks strange when somebody inserts for example number 4 and our plural form is translated only for number 5.

Best solution would be probably some kind of string "Number of posts on page" (without ending "posts" string). But I am not sure about it...

See: https://core.trac.wordpress.org/browser/trunk/src/wp-admin/options-reading.php#L126

[johnbillion]

Does this also affect the various inline fields on the Discussion Settings screen?

[pavelevap]

johnbillion: Yes, good point, I did not notice that.

[SergeyBiryukov]

This is closely related to #13673 and #15576.

Per nacin's comment:

We wouldn't customize this based on the number the user has entered. It should be whatever the maximum plural form is, if I had to guess.

I agree that it looks weird though, perhaps we could reconsider this.

[pavelevap]

Yes, but this could be easier...

What about "Number of posts to show on page" and remove "posts" string entirely?

And "Number of recent posts to show in RSS" and remove "items" string entirely?

[GaryJ]

Patch added which amends the strings.

[SergeyBiryukov]

Seems consistent with [31696], though I'd like to see if we can address comment:1 as well.

[GaryJ]

Replying to SergeyBiryukov:

Seems consistent with [31696], though I'd like to see if we can address comment:1 as well.

Most of the items in Discussions settings are grouped, and have multiple controls i.e. a checkbox and an input field or dropdown.

They are going to need more thought, and they are mutually exclusive to those in Reading settings. A post-commit discussion or a new ticket may be best IMHO.

[SergeyBiryukov]

29299.2.diff​ is what I had in mind:

• Doesn't change the strings, but makes them support proper plural forms.
• Handles the strings on Discussion Settings screen as well.
• Adds translator comments.

[pavelevap]

I would vote for changing strings, because adding plural forms (from latest patch) will not work immediatelly when somebody change values (before saving them).

[johnbillion]

The singular and plural forms in 29299.2.diff​ aren't an improvement because the form won't always be correct when selecting different values.

[SergeyBiryukov]

#46908 was marked as a duplicate.