Merge two strings

[pavelevap]

By removing ending point we can remove the whole string from localization file.

See attached patch.

[SergeyBiryukov]

There's one more instance: tags/3.9.2/src/wp-admin/install.php#L134​.

[pavelevap]

Sorry, I did not notice that one. Thank you, Sergey!

It was not referenced in GlotPress: ​http://translate.wordpress.org/projects/wp/dev/cs/default?filters[status]=either&filters[original_id]=40295&filters[translation_id]=2044734

Patch updated.

[stephdau]

There are only 3 instances of that string (without the ending dot) in the sourcecode.

• The ones you tended to in attachment:29305.patch​
• one instance in wp-admin/options-reading.php

The latter happens to be in a legacy part of the code that is no longer the default.
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/options-reading.php?rev=29628#L148

/**
154	         * Enable the legacy 'Site Visibility' privacy options.
155	         *
156	         * By default the privacy options form displays a single checkbox to 'discourage' search
157	         * engines from indexing the site. Hooking to this action serves a dual purpose:
158	         * 1. Disable the single checkbox in favor of a multiple-choice list of radio buttons.
159	         * 2. Open the door to adding additional radio button choices to the list.
160	         *
161	         * Hooking to this action also converts the 'Search Engine Visibility' heading to the more
162	         * open-ended 'Site Visibility' heading.
163	         *
164	         * @since 2.1.0
165	         */

Maybe we should consider adding an ending dot to the old one instead, and have proper English grammar in all 3 places. Downside being all languages will need to be updated, so I wouldn't do that for 4.0, since we're in string freeze.

[pavelevap]

I selected a variant without dot, because it is standard for many checkboxes, for example "WordPress should correct invalidly nested XHTML automatically", etc. It is not sentence, but label for checkbox, so no need for dot, I guess...

Using my patch we are only removing one string, so there is no need for translators to make any changes? There will be only one string less which is good for memory and translators...

[ocean90]

Related: #27628

[ocean90]

We shouldn't remove the period from wp-signup.php since it's a sentence, not a checkbox label.

I think we should apply [34752] on wp-signup.php too.

[pavelevap]

Yes, there should be definitely checkbox after #27628.

[jeremyfelt]

Replying to ocean90:

I think we should apply [34752] on wp-signup.php too.

I'm +1 on this for 4.4.

[pavelevap]

#34149 will handle not only strings, but the whole checkbox.