WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#29305 closed enhancement (wontfix)

Merge two strings

Reported by: pavelevap Owned by: ocean90
Milestone: Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords:
Focuses: multisite Cc:
PR Number:

Description

By removing ending point we can remove the whole string from localization file.

See attached patch.

Attachments (3)

merge_strings.patch (762 bytes) - added by pavelevap 5 years ago.
29305.patch (1.6 KB) - added by pavelevap 5 years ago.
29305-twentyfifteen-wp-signup.png (141.1 KB) - added by ocean90 4 years ago.

Download all attachments as: .zip

Change History (13)

#2 @pavelevap
5 years ago

Sorry, I did not notice that one. Thank you, Sergey!

It was not referenced in GlotPress: http://translate.wordpress.org/projects/wp/dev/cs/default?filters[status]=either&filters[original_id]=40295&filters[translation_id]=2044734

Patch updated.

@pavelevap
5 years ago

#3 @stephdau
5 years ago

  • Type changed from defect (bug) to enhancement

There are only 3 instances of that string (without the ending dot) in the sourcecode.

The latter happens to be in a legacy part of the code that is no longer the default.
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/options-reading.php?rev=29628#L148

/**
154	         * Enable the legacy 'Site Visibility' privacy options.
155	         *
156	         * By default the privacy options form displays a single checkbox to 'discourage' search
157	         * engines from indexing the site. Hooking to this action serves a dual purpose:
158	         * 1. Disable the single checkbox in favor of a multiple-choice list of radio buttons.
159	         * 2. Open the door to adding additional radio button choices to the list.
160	         *
161	         * Hooking to this action also converts the 'Search Engine Visibility' heading to the more
162	         * open-ended 'Site Visibility' heading.
163	         *
164	         * @since 2.1.0
165	         */

Maybe we should consider adding an ending dot to the old one instead, and have proper English grammar in all 3 places. Downside being all languages will need to be updated, so I wouldn't do that for 4.0, since we're in string freeze.

Last edited 5 years ago by stephdau (previous) (diff)

#4 @pavelevap
5 years ago

I selected a variant without dot, because it is standard for many checkboxes, for example "WordPress should correct invalidly nested XHTML automatically", etc. It is not sentence, but label for checkbox, so no need for dot, I guess...

Using my patch we are only removing one string, so there is no need for translators to make any changes? There will be only one string less which is good for memory and translators...

#5 @ocean90
4 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to ocean90
  • Status changed from new to accepted

Related: #27628

#6 follow-up: @ocean90
4 years ago

  • Component changed from I18N to Login and Registration
  • Focuses multisite added
  • Keywords needs-patch added
  • Milestone changed from 4.4 to Future Release

We shouldn't remove the period from wp-signup.php since it's a sentence, not a checkbox label.

I think we should apply [34752] on wp-signup.php too.

#7 @pavelevap
4 years ago

Yes, there should be definitely checkbox after #27628.

#8 in reply to: ↑ 6 @jeremyfelt
4 years ago

Replying to ocean90:

I think we should apply [34752] on wp-signup.php too.

I'm +1 on this for 4.4.

#9 @pavelevap
4 years ago

  • Resolution set to duplicate
  • Status changed from accepted to closed

#34149 will handle not only strings, but the whole checkbox.

#10 @ocean90
4 years ago

  • Keywords needs-patch removed
  • Milestone Future Release deleted
  • Resolution changed from duplicate to wontfix
Note: See TracTickets for help on using tickets.