Missing i18n in wp-db.php

[SergeyBiryukov]

There's an "Error reconnecting to the database"​ string (introduced in [27075]).

Unlike the "Error establishing a database connection"​ string, it does not use the __() function.

This looks like an omission.

[nacin]

I want to say this was by design as it's too early in the process for strings to be loaded. We would need wp_load_translations_early(), I believe.

It looks like it was also possibly not translated originally because it was possible it was going to change (and it was a huge string). Should we wait until 4.1 to toss this to translators?

[SergeyBiryukov]

29306.2.patch​ adds wp_load_translations_early().

This can wait for 4.1.

[SergeyBiryukov]

In 34943:

Add wp_load_translations_early() to wpdb::check_connection().

Fixes #29306. See #34216.