Make WordPress Core

Opened 12 years ago

Closed 11 years ago

#29336 closed defect (bug) (fixed)

Error messages page does not have the viewport meta tag

Reported by: rellect Owned by: rachelbaker
Priority: normal Milestone: 4.3
Component: Comments Version: 3.8
Severity: normal Keywords: has-patch
Cc: Focuses: ui

Description

Try to send an empty comment, you will get an error that you need to fill the fields. This error page does not have the viewport meta tag, which means this page don't have a responsive style in mobile.

This is tested in 4.0 beta.

Attachments (1)

29336.diff (626 bytes ) - added by leogopal 11 years ago.
Adds the viewport meta tag for mobile assistance.

Download all attachments as: .zip

Change History (8)

@leogopal
11 years ago

Adds the viewport meta tag for mobile assistance.

#1 @leogopal
11 years ago

  • Keywords has-patch added

#2 @rachelbaker
11 years ago

  • Owner set to rachelbaker
  • Status newreviewing

#3 follow-up: @johnbillion
11 years ago

  • Milestone Awaiting Review4.3

How strange. The viewport meta tag got missed in r26299 despite it being in the patch on #25956.

@iammattthomas Was there a reason for this or did it just get missed?

#4 @johnbillion
11 years ago

  • Version 3.9.23.8

#5 in reply to: ↑ 3 @iammattthomas
11 years ago

Replying to johnbillion:

How strange. The viewport meta tag got missed in r26299 despite it being in the patch on #25956.

@iammattthomas Was there a reason for this or did it just get missed?

Hrm, hard to say, given how long ago it was—but given my commit message in r26299 it looks like it was just an oversight on my part:

Update error screens with the new visual design:

  • Bring in new styles for backgrounds/text/link/borders/buttons
  • Switch to device-width for the viewport and tweak margins etc so the layout works nicely on all device sizes
Last edited 11 years ago by iammattthomas (previous) (diff)

#6 @rachelbaker
11 years ago

  • Status reviewingaccepted

Let's fix in 4.3, patch looks good.

Last edited 11 years ago by rachelbaker (previous) (diff)

#7 @johnbillion
11 years ago

  • Resolutionfixed
  • Status acceptedclosed

In 32501:

Add a viewport meta tag to wp_die().

Props leogopal

Fixes #29336

Note: See TracTickets for help on using tickets.