WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#29339 closed defect (bug) (fixed)

At small viewports when there is no menu, the Media Modal title down arrow should not appear

Reported by: gcorne Owned by: helen
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Media Keywords: needs-patch
Focuses: ui Cc:

Description

At small viewports when there is no menu, the Media Modal title down arrow should not appear, the title should probably be dark gray instead of blue, and the cursor should also not be a pointer.

Attachments (4)

media-modal-title.png (42.9 KB) - added by gcorne 6 years ago.
29339.patch (534 bytes) - added by azaozz 6 years ago.
29339.diff (4.1 KB) - added by helen 6 years ago.
29339.2.diff (3.8 KB) - added by helen 6 years ago.

Download all attachments as: .zip

Change History (11)

#1 @helen
6 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.0

#2 @helen
6 years ago

  • Owner set to helen
  • Status changed from new to accepted

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.


6 years ago

#4 @celloexpressions
6 years ago

Not sure what the best approach is here - there currently aren't any classes or anything to indicate whether there's a menu or not in a given instance of the media modal. And in some cases, like with the edit details modal, there is a menu, but it's hidden with css.

We could just use the .image-details class to hide it on that particular modal, but I don't see an existing class that would work for featured images and this generally seems like a bad approach. Maybe we should add a .has-menu or .no-menu class?

#5 @wonderboymusic
6 years ago

In 29613:

Media Modal:

  • the Image Details frame does not have a menu, indicate that by setting menu: false when adding states.
  • mimic the default router rendering by toggling a hide-menu class on the frame when the region for menu is null
  • remove the dead render code for the Image Details frame

See #29339.

@azaozz
6 years ago

#6 @azaozz
6 years ago

29339.patch fixes that from CSS for now. This needs another iteration in 4.1 :)

@helen
6 years ago

@helen
6 years ago

#7 @helen
6 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 29632:

Media modals: Better responsive views, especially the header.

  • Only show the "dropdown" when there is a menu. Note that this uses a :not() selector, but it is supported in browsers that support media queries so it is safe to use here.
  • Make the header shorter when on particularly narrow screens, which also tend to be shorter.
  • Don't restrict the height of images in the attachment details modal, to take advantage of all available space.

fixes #29339.

Note: See TracTickets for help on using tickets.