WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#29355 closed enhancement (maybelater)

Add embed support for thinglink

Reported by: peterchester Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch
Focuses: Cc:
PR Number:

Description

I've tried it out and it appears that thing links embed support is pretty straightforward. All we need is to add it to the list of providers.

Attachments (1)

thinglink.oembed.diff (1.2 KB) - added by peterchester 5 years ago.
Diff file to support thinglink oembed.

Download all attachments as: .zip

Change History (14)

@peterchester
5 years ago

Diff file to support thinglink oembed.

#1 @peterchester
5 years ago

  • Keywords dev-feedback added

#2 follow-up: @ocean90
5 years ago

  • Keywords dev-feedback removed

#3 in reply to: ↑ 2 @peterchester
5 years ago

Excellent questions! I'll ask thinglink to speak to that themselves. I'm passing this on to them now.

#4 @Janne Jalkanen
5 years ago

Hi!

I am Janne, the CTO over at Thinglink. To describe us a bit:

We are the leading provider of interactive images. We have existed for over four years now, so we're not exactly a nascent service. At the writing of this, we are among the Alexa top 16,000 web sites (http://www.alexa.com/siteinfo/thinglink.com) and serve about 700M API calls/month.

We have a Wordpress plugin already in existence (http://wordpress.org/plugins/thinglink/) which has had over 10k downloads. We're quite often badgered by our customers to get the plugin accepted into wordpress.com, and have a few WP VIP customers who are using it.

We have large, established customers such as The New York Magazine, CBSi, The Home Depot, Microsoft, and Forbes. We are also being used quite extensively in the education space (take a look at the twitter stream at https://twitter.com/search?q=thinglink&src=typd to see how people are using us).

Our OEmbed endpoint has been stable for the past couple of years and is officially supported as a part of our API through OEmbed discovery. It would be awesome to have this as a part of WP.

And, yes, we do have a Wikipedia article :-). https://en.wikipedia.org/wiki/Thinglink

In case of further questions, I'd be glad to provide more info!

#5 @peterchester
5 years ago

  • Keywords dev-feedback added

Well there we have it. Thanks Janne!

Dominik? Thoughts?

Oh, one other thing, I marked this as available since 4.0 in the code but i'm assuming this is not in time for the 4.0 release. Should I update that to 4.1? Or just not worry about it?

#6 @peterchester
5 years ago

  • Keywords has-patch added

Hi folks, any chance we can get this into 4.1?

#7 follow-ups: @wonderboymusic
5 years ago

What is the SSL situation here? See #28507

#8 in reply to: ↑ 7 @peterchester
5 years ago

Replying to wonderboymusic:

What is the SSL situation here? See #28507

I'm not sure what you mean by the SSL situation. You can enter SSL or non-SSL thinglink urls and they both work. Is that what you're asking?

Thanks Scott!

#9 @Janne Jalkanen
5 years ago

Thinglink supports both SSL and non-SSL version of the embed (just use https where you would use http; or better yet, use protocol-relative addressing), though the OEmbed spec doesn't say squat about SSL so I'm unsure how that should be handled.

Though if preferred, we can start serving OEmbed through SSL completely too (so that our embeds are always SSL, regardless of whether you query SSL or non-SSL API).

#10 in reply to: ↑ 7 @peterchester
5 years ago

Replying to wonderboymusic:

What is the SSL situation here? See #28507

Hi Scott, any update on what we should be doing here? I'm not sure what you're asking for.

#11 @johnbillion
5 years ago

  • Keywords 2nd-opinion added; dev-feedback removed
  • Milestone changed from Awaiting Review to 4.1
  • Version 4.0 deleted

I'm moving this to the next major release milestone for review (as we tend to do for requests for oEmbed provider support).

As per the whitelsiting oEmbed providers checklist, it's important that oEmbed providers are well established and can be trusted in the long term. I'd hate to add support for an oEmbed provider, only for the service to go bust in six months time and have to be removed.

ThingLink does appear to be quite popular, but I'm not convinced that it's established enough or mainstream enough to be included in core. Both of those metrics are subjective, of course, and I'm open to being persuaded. My concern is that we could probably come up with dozens of online services which have been around for four or five years and have several hundred thousand users. I don't think ThingLink is exceptional enough in that regard.

#12 @ahansson89
5 years ago

I agree with you @johnbillion. It is not up to WP to promote businesses by adding oEmbed support if the majority of the WP users will never use it.

Adding the oEmbed support in a separate plugin for the plugin repo seems like a better idea for ThingLink.

#13 @DrewAPicture
5 years ago

  • Keywords 2nd-opinion removed
  • Milestone 4.1 deleted
  • Resolution set to maybelater
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.