WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#29361 closed defect (bug) (fixed)

Install Plugins: Don't wp_die() if API can't be reached

Reported by: alex-ye Owned by: SergeyBiryukov
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Plugins Keywords: has-patch commit
Focuses: administration Cc:

Description

WordPress 4.0 comes with a lot of changes to the plugin-install page. Something I am not sure about it.. I think we should allow the plugin-install page to work offline because installing a plugin from the uploader doesn't need an internet connection !!

Attachments (2)

29361.diff (1.2 KB) - added by johnbillion 5 years ago.
Screen Shot 2014-08-25 at 13.41.17.png (45.0 KB) - added by johnbillion 5 years ago.

Download all attachments as: .zip

Change History (7)

#1 @ocean90
5 years ago

Not sure I understand you. How can you access your site when you're offline?

#2 @johnbillion
5 years ago

  • Component changed from Administration to Plugins
  • Version set to trunk

A local development environment can be offline, or there can be other reasons a site cannot connect to the wordpress.org API.

Pre-4.0 the Plugins -> Add New screen had a landing page which didn't need a connection to the API, so you could access the Upload tab. In 4.0, this page dies with an error message if the API cannot be contacted.

@johnbillion
5 years ago

#3 @johnbillion
5 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.0

29361.diff gets rid of the wp_die() on this page and instead outputs the error message in the same way that the "no results" message is output.

Moving to 4.0 for consideration, because this was a change in 4.0.

#4 @ocean90
5 years ago

  • Keywords commit added
  • Summary changed from Install a plugin offline to Install Plugins: Don't wp_die() if API can't be reached

#5 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29594:

Install Plugins: Don't wp_die() if API can't be reached.

props johnbillion.
fixes #29361.

Note: See TracTickets for help on using tickets.