WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#29369 closed defect (bug) (fixed)

Plugin Install Pagination on small screens needs padding

Reported by: Ipstenu Owned by: helen
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Plugins Keywords: has-patch
Focuses: Cc:
PR Number:

Description

Props to @acreativecollective for spotting this: http://wordpress.org/support/topic/plugin-installphp-pagination-missing-margin-top?replies=1

Full screen: https://cloudup.com/cNLRY45Js6L
Small screen: https://cloudup.com/czqO4ted6Lx

There's a need for padding on that media size.

Patch attached

Attachments (2)

29369.diff (371 bytes) - added by Ipstenu 5 years ago.
CSS change
29369.2.diff (326 bytes) - added by stephdau 5 years ago.
A Different take on the fix, as an option.

Download all attachments as: .zip

Change History (9)

@Ipstenu
5 years ago

CSS change

This ticket was mentioned in IRC in #wordpress-dev by stephdau. View the logs.


5 years ago

@stephdau
5 years ago

A Different take on the fix, as an option.

#2 @stephdau
5 years ago

I've tried your patch, and it looks great, fixes the bug listed on this ticket. See https://cloudup.com/co88KoMmRFr

On the other hand, I checked where else .tablenav.top (list-tables) is used, and it looks like we usually go for more room around the navbar (though never really with symmetrical top and border margins anywhere)

attachment:29369.2.diff addresses the top margin issue in the plugins search results, but also homogenizes the toolbar in other instances (IMHO). See https://cloudup.com/cVLcfAQRY5I

#3 @stephdau
5 years ago

  • Keywords has-patch added

#4 @stephdau
5 years ago

Note: both patches still apply fine after r29625.

Mine: https://cloudup.com/cIP4ct5K6y9

ipstenu's: https://cloudup.com/cIJg5_JSk-d

#5 @helen
5 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 29627:

Give pagination controls some breathing room on smaller screens.

props stephdau.
fixes #29369.

#6 @helen
5 years ago

  • Milestone changed from Awaiting Review to 4.0

#7 @stephdau
5 years ago

#29279 was marked as a duplicate.

Note: See TracTickets for help on using tickets.