WordPress.org

Make WordPress Core

Opened 15 years ago

Closed 14 years ago

#2937 closed enhancement (worksforme)

Make Yes/No dialog uniform in appearance

Reported by: markjaquith Owned by: markjaquith
Milestone: Priority: normal
Severity: normal Version: 2.1
Component: Administration Keywords: needs-patch
Focuses: Cc:

Description

The yes/no nonce dialog uses an HTML link for the "no" selection, and the "yes" selection is a form submit button for POST requests and an HTML link for GET requests.

The dialog should be uniform in appearance. The yes and no buttons should both use form submit buttons, regardless of request method.

Attachments (2)

uniform_yes_no_dialog_001.diff (2.4 KB) - added by markjaquith 15 years ago.
First attempt, for /trunk/
2937_uniform_yes_no_dialog_002.diff (2.7 KB) - added by mdawaffe 15 years ago.
clean some old stuff up

Download all attachments as: .zip

Change History (10)

#1 @Viper007Bond
15 years ago

  • Type changed from defect to enhancement

@markjaquith
15 years ago

First attempt, for /trunk/

#2 @markjaquith
15 years ago

  • Status changed from new to assigned

First attempt. Consolidates the HTML so that it's the same for GET/POST. Uses a separate HTML form for No and Yes. Inline CSS is used to float the forms. This can be moved to the stylesheet once we're happy with it... so don't judge the patch based on the use of inline style.

@mdawaffe
15 years ago

clean some old stuff up

#3 @mdawaffe
15 years ago

While we're at it, can we clean up a couple of things?

Based on your patch, 2937_uniform_yes_no_dialog_002.diff:

  1. list() looks pretty
  2. Make sure we only have one _wpnonce field to prevent weird browser bugs from popping up.
  3. "No: Cancel", "Yes: Go ahead". Does this make things less scary?

We should also note that we do not need the or fade class (or the confirm class) here since wp_die doesn't use fat.js.

#4 @Nazgul
15 years ago

  • Keywords has-patch added

#5 @matt
15 years ago

  • Milestone changed from 2.1 to 2.2

#6 @markjaquith
15 years ago

  • Keywords needs-patch added; has-patch removed

Needs a new patch.

#7 @foolswisdom
15 years ago

  • Milestone changed from 2.2 to 2.4

#8 @pishmishy
14 years ago

  • Milestone 2.5 deleted
  • Resolution set to worksforme
  • Status changed from assigned to closed

I'm not sure this bug is relevant in the current code. wp_nonce_ays() appears to do something differently. I'll close for now, reopen if I'm wrong please.

Note: See TracTickets for help on using tickets.