Make WordPress Core

Opened 19 years ago

Closed 18 years ago

Last modified 18 years ago

#2938 closed enhancement (fixed)

Don't have a category selected by default

Reported by: viper007bond's profile Viper007Bond Owned by: markjaquith's profile markjaquith
Milestone: 2.1 Priority: low
Severity: minor Version: 2.0.4
Component: Administration Keywords: bg|has-patch commit
Focuses: Cc:

Description

It drives me nuts having to uncheck the box next to my default category when writing a new post if I don't want it in that category.

How about we just don't check any boxes off the bat and only then if the user doesn't pick any categories, we assign it to the default category?

I see no drawback to doing this. Does anyone else?

I'll have a patch shortly probably.

Attachments (2)

edit-form-advanced.php.diff (548 bytes) - added by darkfate 19 years ago.
patch from Viper007Bond, "now in upload form!"
uncheck-default-category.php (634 bytes) - added by mdawaffe 19 years ago.
JS Plugin

Download all attachments as: .zip

Change History (12)

#1 @Viper007Bond
19 years ago

  • Keywords bg|has-patch added
  • Milestone set to 2.1

Well, I edited /wp-admin/edit-form-advanced.php, but TortoiseSVN is being retarded and not realizing that I made any changes which means I can't make a patch.

So instead, here's the needed code change (on line 77):

<ul id="categorychecklist"><?php dropdown_categories(get_settings('default_category')); ?></ul></div>

to this:

<ul id="categorychecklist"><?php dropdown_categories(); ?></ul></div>

I tested it and it seems to work fine. :)

#2 @darkfate
19 years ago

I found a trick to get TortoiseSVN to think the file has changed. Rename edit-form-advanced.php to something like edit-form-advanced1.php. Then run an update and tortoiseSVN will restore the file. Delete that file and rename edit-form-advanced1.php back to edit-form-advanced.php and it should show a red exclamation point. Then you can create the patch. That's what I do all the time.

@darkfate
19 years ago

patch from Viper007Bond, "now in upload form!"

#3 @mdawaffe
19 years ago

I've attached the JS I have used previously to do this.

I have conflicted opinions about what the core should do.

#4 @filosofo
19 years ago

If anyone's interested, here is my plugin that uses JavaScript to uncheck the default category, if someone checks another.

@mdawaffe
19 years ago

JS Plugin

#5 @markjaquith
18 years ago

  • Keywords commit added
  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

+1

Default category will be selected if the post is published with no category selected... no need to pre-select the default. I often forget to uncheck the default one so my posts go in "Foo and Uncategorized."

#6 @markjaquith
18 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4310]) default category starts out unchecked. Props Viper007Bond. fixes #2938

#7 @markjaquith
18 years ago

(In [4311]) default category starts out unchecked. Props Viper007Bond. fixes #2938

#8 @markjaquith
18 years ago

  • Milestone changed from 2.1 to 2.0.5

Now the default category only acts as a last resort when no categories have been defined.

#9 @markjaquith
18 years ago

  • Version changed from 2.1 to 2.0.4

#10 @markjaquith
18 years ago

  • Milestone changed from 2.0.5 to 2.1

[4406] Saving the default-category behavior change for 2.1

Note: See TracTickets for help on using tickets.