Autosave message should disappear when the next autosave happens

[iseulde]

An autosave overwrites the previous autosave, so the message is no longer relevant. It will just display the same content as the current editor.

[adamsilverstein]

Remove the 'Newer autosave exists message' when autosaving

[adamsilverstein]

Good point, thats confusing!

In 29386.diff​

Remove the 'Newer autosave exists message' when autosaving;

[stephdau]

Tested patch, works as advertised.

[azaozz]

If I remember right, the main reason it doesn't disappear is because that moves the whole screen about 50px up. Pretty annoying while typing.

[adamsilverstein]

Replying to azaozz:

If I remember right, the main reason it doesn't disappear is because that moves the whole screen about 50px up. Pretty annoying while typing.

I can see how that would be annoying, any ideas to alleviate that? once the autosave fires and matches the current content, the message is wrong - ​http://cl.ly/image/2n3P3H0W1W2w

how about fade out the message, then maybe remove it on the next blur from any input field?

[iseulde]

Fade out would leave a big gap. I think it's better to do it on mousemove. We should think about touch devices too though. :)
I'm also not sure why the only child of a parent that has an id needs an id too, so I removed it in the patch.

[iseulde]

Can also scroll up the difference, if the page is scrolled down a bit. (See patch.)

[adamsilverstein]

Seems to address the issue azaozz raised. Not sure about mobile, also if you navigate entirely with keyboard the removal never fires.

How about - if tinymce has focus, remove on blur, if tinymce doesn't have focus remove immediately?

[azaozz]

Replying to avryl:

I'm also not sure why the only child of a parent that has an id needs an id too, so I removed it in the patch.

The id is needed so we don't show two "restore" warnings (from the server and sessionStorage), used in autosave.js.

[iseulde]

Replying to azaozz:

The id is needed so we don't show two "restore" warnings (from the server and sessionStorage), used in autosave.js.

We can use #notice?

[azaozz]

Nope, this is for all notices. There can be 2-3 there at some point (there are plugins adding notices to all screens...).

[iseulde]

With the ID notice? That's not good. Maybe we can change #notice to #has-newer-autosave and remove it from the child p.

[azaozz]

Yeah, duplicate IDs. Think that's been around for many years, hasn't been fixed because of back-compat.

[azaozz]

Replying to avryl:

On the other hand, the styling that (I think) used to use #notice is long gone. Perhaps we can ignore any additional div#notice and use that for detecting the "Has newer autosave.." one.