Notice on install screen.

[markoheijnen]

It's an edge case so unsure if we need to patch it. There are a same check in block_request() but that one really seems trivial.

[stephdau]

Edge case or not, I'd add the test you have in your patch. You could also replace isset() by empty(), and the test would also stop there whether not set or empty. Regardless, I think we're better off with one more edge case test than missing it when needed (since the perf cost is trivial). :)

[SergeyBiryukov]

See also #28648 and [28865].

29392.2.diff​ makes all three checks consistent.

[nacin]

If we're going to do if ( 'localhost' == $check['host'] || isset( $home['host'] ) && $home['host'] == $check['host'] ) I'd like parentheses around isset( $home['host'] ) && $home['host'] == $check['host'] so it's absolutely clear as to the order of operations.

Otherwise, this is good.

[SergeyBiryukov]

29392.3.diff​ adds parentheses.

[SergeyBiryukov]

In 29661:

Avoid PHP notices when checking for local requests in in WP_Http.

props markoheijnen.
fixes #29392.