WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#29397 closed defect (bug) (fixed)

Language Install: Check if WordPress has access to the filesystem without asking for credentials

Reported by: ocean90 Owned by: ocean90
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Upgrade/Install Keywords: has-patch commit dev-reviewed
Focuses: Cc:

Description

Currently the language chooser is displayed even when WordPress has no access to the filesystem. We should skip it in this case.

Related: #29395

Attachments (2)

29397.patch (2.2 KB) - added by ocean90 5 years ago.
29397.2.patch (2.4 KB) - added by ocean90 5 years ago.

Download all attachments as: .zip

Change History (9)

@ocean90
5 years ago

#1 @johnbillion
5 years ago

It'd be nice to display some sort of error message in this case, but it may be unnecessarily confusing for a new install. On the other hand, it would be confusing if a user was expecting to be able to choose their language here and saw no means to do so, yet saw no error message either.

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.


5 years ago

#3 @nacin
5 years ago

  • Keywords commit dev-reviewed added

The UX in this patch is what I intended — it would skip the process if the FS or API wasn't available. So, this is good. I might want to study the function name but it's good otherwise.

#4 @nacin
5 years ago

  • Keywords needs-patch added; has-patch commit dev-reviewed removed

Can we also resolve the @todo in wp_download_language_pack()? Should be just simple enough to check the return value, I think.

@ocean90
5 years ago

#5 @ocean90
5 years ago

  • Keywords has-patch added; needs-patch removed

#6 @nacin
5 years ago

  • Keywords commit dev-reviewed added

#7 @ocean90
5 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 29673:

Install: Only show the language chooser when we have access to the filesystem without asking for credentials.

fixes #29397.

Note: See TracTickets for help on using tickets.