WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#29404 closed enhancement (fixed)

Confusing Media Grid message when there is no media uploaded

Reported by: gluten Owned by: helen
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Text Changes Keywords: commit has-patch dev-reviewed
Focuses: ui, administration Cc:

Description

When I open the media library grid view in WordPress 4.0-RC1 for a website which does not have any media uploads I get the message "No media found. Try a different search." I see this message even if I have not performed a search.

The message in the list view says "No media attachments found." This message makes much more sense when there are no uploads, and still works for a search with no results. It also seems like whatever the text is, it should consistent across both media library views.

Attachments (1)

29404.diff (378 bytes) - added by voldemortensen 7 years ago.
Patch according to description.

Download all attachments as: .zip

Change History (9)

#1 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 4.0

Introduced in [29136].

@voldemortensen
7 years ago

Patch according to description.

#2 @voldemortensen
7 years ago

A point to bring up, the "Try a different search." wording is also in theme-install.php

./wp-admin/theme-install.php: <p class="no-themes"><?php _e( 'No themes found. Try a different search.' ); ?></p>

However, I think this wouldn't need to be changed because that wording doesn't show when initially visiting /wp-admin/theme-install.php. It will only trigger on a bad search.

#3 @helen
7 years ago

  • Keywords commit added

I'm good with this for 4.0 - we can look at a better empty library prompt in 4.1 (as opposed to a different prompt for a search with no results).

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.


7 years ago

#5 @nacin
7 years ago

  • Keywords has-patch dev-reviewed added

Looks good.

#6 @helen
7 years ago

  • Keywords has-patch dev-reviewed removed

voldemortensen - no need to worry about this for this patch, but in the future, please make patches from the root of the repo. There are multiple media.php files :)

#7 @helen
7 years ago

  • Keywords has-patch dev-reviewed added

#8 @helen
7 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 29655:

Media grid: Don't show a misleading message for an empty library.

This uses the existing string from the list table. We should revisit a better overall experience for the two situations (empty library vs. search with no results) in 4.1.

props voldemortensen.
fixes #29404.

Note: See TracTickets for help on using tickets.