WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#29428 closed defect (bug) (fixed)

TED Talk Oembeds Show Portrait Frame with Landscape Video

Reported by: andrejcarter Owned by:
Milestone: 4.0 Priority: low
Severity: normal Version: 4.0
Component: Embeds Keywords:
Focuses: Cc:

Description

I'm using 4.0RC1 with Twenty Fourteen. The TED Talk embeds aren't showing as I'd expect them to. Prior to hitting play the still video is showing in portrait and filling up the entire video window. Once I hit play the window remains portrait, but the video playing inside of it is landscape with black space above and below. I've attached pictures.

Attachments (2)

Ted Playing.png (505.6 KB) - added by andrejcarter 7 years ago.
Ted Talk video playing
Ted Still.png (881.6 KB) - added by andrejcarter 7 years ago.
Ted Talk video before playing

Download all attachments as: .zip

Change History (14)

@andrejcarter
7 years ago

Ted Talk video playing

@andrejcarter
7 years ago

Ted Talk video before playing

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.


7 years ago

#2 @helen
7 years ago

  • Milestone changed from Awaiting Review to 4.0

Moving for investigation and resolution.

#3 @ocean90
7 years ago

  • Priority changed from normal to highest omg bbq

At the current state we have to remove TED from the whitelist. Since this effects also the about page I'm raising the priority.

#4 @johnbillion
7 years ago

Just to confirm, this issue is specific to TED's oEmbed endpoint. If you use the embed code provided on any video page on TED, the video appears as expected:

https://i.imgur.com/rd6cmcJ.png

#5 @andrejcarter
7 years ago

I embedded the same video on a live site here - http://ajorel.com/2014/ted-talk-embeds/. The exact line I used to oembed is also below.

http://www.ted.com/talks/sally_kohn_don_t_like_clickbait_don_t_click

#6 @helen
7 years ago

Per IRC:

johnbillion: the height should be proportional to the video's width, and cast the maxwidth and maxheight to positive integers

#7 @helen
7 years ago

TED's developer is looking at this now.

#8 @nacin
7 years ago

  • Priority changed from highest omg bbq to normal

helen and I have been told TED.com will have this deployed at 10am ET on Sept 3. If by the time we're ready to release it's not working, we'll change the string and have translators translate it on the fly before releasing.

#9 @nacin
7 years ago

  • Priority changed from normal to low

#10 @helen
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

TED pushed the changes live a little while ago and it is looking good to keep. Noting some observations about maxwidth/maxheight values with them, but it is not a dealbreaker. With thanks to George and Bedirhan at TED, and jaragozzine for the communication assist, as well as everybody else who dove in to test and investigate yesterday.

#11 @summoner
7 years ago

So Ted talks better at last? ;-)
Yay, it seems this was the last ticket for a while.

#12 @padraigbeirne
7 years ago

Thanks to andrejcarter for reporting the issue.

Note: See TracTickets for help on using tickets.