Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#29448 closed defect (bug) (fixed)

Media: Untranslated Strings

Reported by: alex-ye's profile alex-ye Owned by: helen's profile helen
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Media Keywords: has-patch commit dev-reviewed
Focuses: administration Cc:

Description

Some strings are not translated in the new Media screen (WordPress 4.0).

Attachments (1)

media-table.patch (702 bytes) - added by alex-ye 11 years ago.

Download all attachments as: .zip

Change History (5)

#1 follow-up: @SergeyBiryukov
11 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.0
  • Version set to trunk

Looks good.

The string already exists, not in the admin project though (not sure if that makes a difference for GlotPress). We could probably copy the value from the main project so that translators don't have to do that.

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.


11 years ago

#3 in reply to: ↑ 1 @nacin
11 years ago

  • Keywords commit dev-reviewed added

Replying to SergeyBiryukov:

Looks good.

The string already exists, not in the admin project though (not sure if that makes a difference for GlotPress). We could probably copy the value from the main project so that translators don't have to do that.

Any strings used outside the admin are omitted from the admin project even if they're there too, as the main frontend MO is always loaded.

Removing the only frontend instance of a string that is also used in the admin will end up making it untranslated in the admin project, but that's not the case here.

#4 @helen
11 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 29659:

Media: Translate a string for the search placeholder.

props alex-ye.
fixes #29448.

Note: See TracTickets for help on using tickets.