Install screen has no RTL

[ramiy]

The new install screen, after selecting an RTL language (in my case Hebrew), has no RTL support.

[johnbillion]

Argh, there's no RTL flag on the languages returned by the Translations API. If there was, we could switch the text direction on this screen in the same way we switch the button text.

[johnbillion]

Patch coming up.

[ocean90]

29452.patch​ re-inits $GLOBALS['wp_locale'] after the default textdomain has changed.

Note: This only works in /build.

[johnbillion]

Dominik's patch was simpler than mine, so I've just extended that. 29452.diff​ also displays the WP_Locale::rtl_src_admin_notice() message on the install and setup-config screens when you're running src.

[johnbillion]

29452.diff​ forgot the version check. Let's try 29452.2.diff​.

Running src:

Not running src (or fudging your version number):

[nacin]

I'm fine with just 29452.patch​ for 4.0.

[SergeyBiryukov]

There's a typo in 29452.patch​ in line 207, should be $GLOBALS.

[pento]

attachment:29452.2.patch​ fixes the typo in attachment:29452.patch​

[SergeyBiryukov]

In 29669:

Re-initialize $wp_locale global after changing the default textdomain on installation screens.

props ocean90.
fixes #29452.

[SergeyBiryukov]

Found a related issue while testing this: #29464.