#29452 closed defect (bug) (fixed)
Install screen has no RTL
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.0 | Priority: | normal |
| Severity: | normal | Version: | 4.0 |
| Component: | Upgrade/Install | Keywords: | has-patch commit dev-reviewed |
| Focuses: | rtl | Cc: |
Description
The new install screen, after selecting an RTL language (in my case Hebrew), has no RTL support.
Attachments (8)
Change History (21)
#1
@
10 years ago
- Component changed from General to Upgrade/Install
- Milestone changed from Awaiting Review to 4.0
This ticket was mentioned in IRC in #wordpress-dev by johnbillion. View the logs.
10 years ago
#5
@
10 years ago
29452.patch re-inits $GLOBALS['wp_locale'] after the default textdomain has changed.
Note: This only works in /build.
#6
@
10 years ago
- Keywords has-patch added
Dominik's patch was simpler than mine, so I've just extended that. 29452.diff also displays the WP_Locale::rtl_src_admin_notice() message on the install and setup-config screens when you're running src.
#7
@
10 years ago
29452.diff forgot the version check. Let's try 29452.2.diff.
Running src:
Not running src (or fudging your version number):
#9
@
10 years ago
There's a typo in 29452.patch in line 207, should be $GLOBALS.
#10
@
10 years ago
attachment:29452.2.patch fixes the typo in attachment:29452.patch
Argh, there's no RTL flag on the languages returned by the Translations API. If there was, we could switch the text direction on this screen in the same way we switch the button text.