Change the default orderby in wp_get_nav_menus()

[pento]

In #28126, we changed the orderby that is passed to wp_get_nav_menus() to name. For a more complete solution, we should make this the default orderby in wp_get_nav_menus(), rather than none.

[voldemortensen]

Removed changes made by #28126 and changed the default orderby to 'name'.

[pento]

Nice. There are a few other places in core where wp_get_nav_menus() is called with 'orderby' => 'name' (which can be removed), or called without an orderby parameter (which need to be tested, to make sure they don't break existing behaviour).

This could also do with some unit tests.

[voldemortensen]

Removed all the instances of 'orderby' => 'name' I could find passed in wp_get_nav_menus(). Kept the default at 'orderby' => 'name'.

[igmoweb]

Unit tests included

[SergeyBiryukov]

In 29792:

Change the default orderby value in wp_get_nav_menus() to 'name'.

props voldemortensen, igmoweb.
fixes #29460.

[DrewAPicture]

Sorry, late to the party here.

I'd like to see an additional @since 4.1.0 tag added to the docblock for wp_get_nav_menus() specifying that the default 'orderby' argument value changed from 'none' to 'name'.

[curtjen]

Added code documentation for changing "none" to "name" for wp_get_nav_menus().

[DrewAPicture]

In 29796:

Update documentation for wp_get_nav_menus() to reflect that the default value for the the 'orderby' argument was changed from 'none' to 'name' in 4.1.

Props curtjen.
Fixes #29460.

[nacin]

I'd consider this change to be internal enough to not warrant a special @since as added in [29796]. I'm all for using these @since lines when there are changes to arguments or other major changes. This falls way down the slippery slope as to what warrants an @since and what doesn't. My two cents.

[DrewAPicture]

I think anytime we're dealing with something that could be construed as a "default" value -- making a change like this needs to be documented as part of the overall "changelog" for that function.

That goes for actual arguments supplied to the function, as well as array items of arguments (which we're now documenting through hash notations). I think it was a lot easier to dismiss notating these changes before we started documenting them, but now it's time to have a little more accountability in core saying, "no, you aren't crazy, we changed this. And this is when."