Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#29464 closed defect (bug) (fixed)

setup-config.php should use RTL CSS files

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.0 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch commit dev-reviewed
Focuses: ui, rtl Cc:


Background: #29452

For RTL, we have install-rtl.css and buttons-rtl.css files. We use them in install.php, but not in setup-config.php. This leads to misplaced list, fields, and button (see the screenshots).

This is not a regression, but seems trivial to fix. We use wp_admin_css() in install.php, and it works fine in setup-config.php too.

Attachments (5)

29464.step1.png (35.6 KB) - added by SergeyBiryukov 10 years ago.
29464.step2.png (31.1 KB) - added by SergeyBiryukov 10 years ago.
29464.patch (1.3 KB) - added by SergeyBiryukov 10 years ago.
29464.step1.after.png (38.9 KB) - added by SergeyBiryukov 10 years ago.
29464.step2.after.png (31.2 KB) - added by SergeyBiryukov 10 years ago.

Download all attachments as: .zip

Change History (10)

#1 @SergeyBiryukov
10 years ago

buttons.css is already a dependency of install.css.

#2 @nacin
10 years ago

Ah yes, we can do this now that we're bootstrapping WordPress. No side effects noticed? It should be fine, as the only difference between setup-config.php and install.php now is just one has a DB connection and one doesn't.

#3 @SergeyBiryukov
10 years ago

Didn't see any side effects with 29464.patch.

#4 @nacin
10 years ago

  • Keywords commit dev-reviewed added

Works for me.

#5 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29670:

Use wp_admin_css() to enqueue stylesheets in setup-config.php.

fixes #29464.

Note: See TracTickets for help on using tickets.