is_object_in_term() return true If the term name begins with a number

[nobinobi]

If the term name begins with a number Might return true even if the post not belongs to a taxonomy term

this code return true

$object_term->term_id = 10;
$strs = array("10_term_name");

if ( in_array( $object_term->term_id, $strs ) ) return true;

change to

if ( in_array( $object_term->term_id, $strs , true ) ) return true;

[SergeyBiryukov]

Related: #24674

[realloc]

Unit test for the ticket #29467

[realloc]

The function filters the integers and compares them before the mentioned line will be executed.

[DrewAPicture]

We only use worksforme when we can't reproduce a bug, it doesn't have anything to do with the patch/unit tests workflow. Reopening :)

[realloc]

@DrewAPicture Oh, sorry for that. Seems I should read the contributors handbook more accurately. ;)

Anyway I could not reproduce this problem.

[boonebgorges]

nobinobi - Thanks for the report and the suggested fix.

realloc - Thanks for writing up the unit test. It's almost right: the issue that nobinobi only arises if you concatenate a term string *that begins with the ID of a term that the post belongs to*, not the ID of the post itself.

[boonebgorges]

In 30204:

Add some unit tests for is_object_in_term().

These tests check a number of the ways that different kinds of values for
$terms (integers that match term_id, strings that match term_id or name or
slug) are handled.

See #29467.

[boonebgorges]

In 30205:

In in_object_in_term(), only check numeric string values against term_id.

The previous in_array() check was playing too loose with mixed types, such
that a string like '10_term_name' would incorrectly match a term_id 10.

Props nobinobi, realloc.
Fixes #29467.