Opened 10 years ago
Closed 9 years ago
#29471 closed enhancement (fixed)
add class for parent div on wpcolorpicker
Reported by: | norcross | Owned by: | wonderboymusic |
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | minor | Version: | 4.0 |
Component: | Widgets | Keywords: | has-patch |
Focuses: | javascript | Cc: |
Description
currently the wpColorPicker function adds the class a.wp-color-open
to the button link a.wp-color-result
, however, there is nothing done to the parent div (wp-picker-container
). adding a class to the parent will allow devs to style the entire container, which includes the button, input field, optional default button, and palette itself.
Attachments (1)
Change History (8)
#1
@
10 years ago
- Keywords has-patch 2nd-opinion needs-testing added
- Severity changed from normal to minor
#2
@
10 years ago
I have a patch for the minified version as well, but wasn't sure if that needed to be submitted
#4
@
10 years ago
also, a bit of background: due to the event.stopPropagation()
on the click action, it's extremely difficult to reliably attach any additional actions to it
#5
@
10 years ago
Sure, looks fine to me. I don't think you need to bother with the minified version, that gets taken care of by the committer.
adds an addClass and removeClass action for the wrap