Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#29498 closed defect (bug) (fixed)

Media grid details shouldn't use full size image

Reported by: nacin's profile nacin Owned by: nacin's profile nacin
Milestone: 4.0 Priority: high
Severity: critical Version: 4.0
Component: Media Keywords: has-patch commit dev-reviewed
Focuses: performance Cc:

Description

The media grid details overlay uses the full size image. This can easily be a 10MB photo, which is really, really bad. Instead, it should use the large size image, which is more or less how post.php for attachments works.

If the large size doesn't exist, we can assume one of two things:

  • The image is smaller than large, so we can and should use full.
  • Someone has deregistered the large size. Let's use full there.

Attachments (1)

29498.diff (807 bytes) - added by nacin 10 years ago.

Download all attachments as: .zip

Change History (5)

@nacin
10 years ago

#1 @helen
10 years ago

  • Keywords dev-reviewed added

#2 @ocean90
10 years ago

29498.diff works as expected.

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.


10 years ago

#4 @nacin
10 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 29704:

Media grid details: Load large images instead of originals, if available.

fixes #29498.

Note: See TracTickets for help on using tickets.