$site_mimes is not defined

[rmccue]

Error in the multisite tests:

Undefined variable: site_mimes

Naive patch attached. Might want to look into why $site_exts is empty though.

[rmccue]

Define $site_mimes before using it

[rmccue]

Default upload_filetypes to the same as the admin

[rmccue]

New patch uses jpg jpeg png gif as the default value, which matches the default for the option in Upload Settings (for the network).

[SergeyBiryukov]

In 29718:

• Declare $site_mimes before using it in check_upload_mimes().
• Use the same default value for 'upload_filetypes' as on Network Settings screen.

props rmccue.
fixes #29512 for trunk.

[SergeyBiryukov]

Reopening for 4.0.1 consideration.

[jeremyfelt]

29512.3.diff applies cleanly to the 4.0 branch.

This is clear to merge to 4.0 as there are no side effects. However this is not a regression from 3.9 so it could also stay as a trunk fix only.

I am able to reproduce the error in 4.0 unit tests, likely because of an option being stomped in a previous test.

[helen]

If there are no other changes in this file, it's better to leave it for 4.1.

[jeremyfelt]

We *could* change the patch to only modify ms-functions.php, which will be changed in #29692, as the other part of the patch is really just a code style change.

That said, the worst this will do is cause a notice, and I haven't found a plausible real world scenario outside of the tests in 4.0.

So I'm going to close it as fixed in 4.1. :)