WP 4.0 "add media" button on edit page not functioning

[lcody]

Happens on edit.php

console returns this error on page load:

Uncaught Error: Syntax error, unrecognized expression: [name=] load-scripts.php?c=1&load%5B%5D=jquery-core,jquery-migrate,utils,plupload,json2&ver=4.0:2

and console returns this error onclick of 'add media' button:

Uncaught TypeError: Cannot read property 'hasClass' of undefined load-scripts.php?c=1&load%5B%5D=hoverIntent,common,admin-bar,schedule,wp-ajax-response,autosave,jqu…:1045

[SergeyBiryukov]

Does it still happen with all plugins disabled and a default theme (Twenty Fourteen or Twenty Thirteen) activated?

[lcody]

My bad, plugin caused the issue. I thought I had updated it, but apparently I had not.

[nacin]

What was the plugin? We don't like it when things break in an update, even if it's the plugin's "fault," so it helps to know so we can look into it.

[lcody]

Plugin was Post Types Order, found at ​https://wordpress.org/plugins/post-types-order/. Updating the plugin fixed all issues.

[ccwtech]

I'm having the same issue. Not using that plug in. Any ideas?

[SergeyBiryukov]

Replying to ccwtech:

I'm having the same issue. Not using that plug in. Any ideas?

1. Does it still happen with all plugins disabled and a default theme (Twenty Fourteen or Twenty Thirteen) activated?
2. Are there any ​JavaScript errors in your browser?

[ccwtech]

In this case it was this plugin for me. Disabling it fixed the issue.
Comprehensive Google Map Plugin
Activate | Edit | Delete
A simple and intuitive, yet elegant and fully documented Google map plugin that installs as a widget and a short code. The plugin is packed with useful features. Widget and shortcode enabled. Offers extensive configuration options for markers, over 250 custom marker icons, marker Geo mashup, controls, size, KML files, location by latitude/longitude, location by address, info window, directions, traffic/bike lanes and more.

Version 9.0.20 | By Alex Zagniotov | View details

[ericlewis]

This is because plugins are depending on functionality in wp-admin/js/media.js, in which we're bootstrapping media grid.

We need a conditional check around the wp.media() call to ensure this only runs on the media grid page.

[ericlewis]

Not sure about the best approach here.

We need awareness in Javascript whether we're on the media grid page vs. any other page (including the Media list page).

A conditional like document.body.className.indexOf( 'upload-php' ) !== -1 comes to mind, but this is also returns true if we're on the Media list page.

[guyerb]

The Comprehensive Google Map plugin is also keep Yoast SEO per-page options from displaying correctly. This sounds like a seperate issue?

​http://wordpress.org/support/topic/seo-options-not-there-since-40?replies=21#post-5981158

[azaozz]

Replying to ericlewis:

We need awareness in Javascript whether we're on the media grid page vs. any other page (including the Media list page).

As the media grid still uses <div class="wrap"> as the "main wrapper", we can easily add an ID to it from PHP and look for that from JS. Don't think it would need anything more complex.

[azaozz]

29520.patch works well here.

Not sure this is the only problem with these plugins though, looking further.

[azaozz]

Don't see JS errors with the patch and the above plugin enabled.

[SergeyBiryukov]

In 29725:

Make sure we're on the media grid page before calling wp.media().

props azaozz.
fixes #29520 for trunk.

[SergeyBiryukov]

Reopening for 4.0.1.

[wonderboymusic]

#29575 was marked as a duplicate.

[Fadookie]

I was seeing this on a clean install of 4.0 also. First off I turned off CONCATENATE_SCRIPTS in wp-config. This showed that there was a 403 accessing jquery. So it was my bad as I'm the maintainer of my site, but this is a pretty gnarly breakage in my case that was difficult to track down.

[jorbin]

I confirmed that r29725 applies cleanly to the 4.0 branch and fixes the issue that is present when used in conjunction with the previous version of the comprehensive-google-map-plugin plugin.

This is ready to be merged.

[nacin]

In 30254:

Make sure we're on the media grid page before calling wp.media().

Merges [29725] to the 4.0 branch.

props azaozz.
fixes #29520.