Number of available updates showing as NaN after completing updates

[circuuz]

When a single plugin or several plugins is updated the notification of how many updates are available on the "Updates" panel in the admin menu is showing as NaN.
This bug reveals itself both when updating from "update-core.php" and "plugins.php".

See screenshots below:

[karpstrucking]

I wasn't able to re-create this on a fresh 4.0 installation. In your screenshot, the plugin you are updating appears to be a premium plugin, not one hosted in the WP.org repository - I suspect this may be related. Can you try to re-create using a plugin from WP.org and/or a different premium plugin?

[circuuz]

I wasn't actually related to the premium plugin but actually to my custom theme.
Can't blame core for that :)

[karpstrucking]

In my office we always blame "Chris" when things go awry (we don't have a "Chris").

[nacin]

Hi circuuz, could you share what your theme was doing, so we have a better idea on how this broke for you?

[jdgrimes]

I just accidentally reproduced this on trunk. I wasn't using the default theme, so it is possible that it theme related in this case as well, but I doubt it. It doesn't happen every time — just once so far.

I'd like to second nacin's query: circuuz, could you share more info on what was causing this?

[jdgrimes]

Check for NaN

[jdgrimes]

29527.diff​ checks if the count is NaN before updating it.

I'm not sure why this happens, but I have a hunch that it is caused by the update count being empty when the page is loaded. That could happen if the updates transients were to get flushed, and the update APIs didn't respond with any updates. In my case, I think that might be happening because I was testing a custom API for retrieving updates for a plugin. I enabled it to get the update, but I disabled it again before running the update.

So, it's possible the only way that a user could cause this is if they are hacking around with stuff. On the other hand it's a rather trivial patch. I'll leave the decision on whether it's needed up to y'all. :-)

[SergeyBiryukov]

In 29960:

In wp.updates.decrementCount(), only display the count if it's a valid non-negative integer.

props jdgrimes.
fixes #29527.

[RMarks]

Before NaN

[RMarks]

After NaN

[RMarks]

I see this is closed, but I also saw people asking how this occurred and if this was related to another plugin. I came across this on a production multisite running 4.0. I had 4 updates pending: 3 for themes and 1 for a plugin. I updated the plugin and then used the update now links shown under each of the following themes: TwentyTwelve, TwentyThirteen, and TwentyFourteen. After updated TwentyFourteen, I saw the NaN next to Updates. Screenshots are above.