WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#29528 closed defect (bug) (fixed)

Fresh Install 4.0 Still asks to upgrade EN_GB

Reported by: jag1989 Owned by: nacin
Milestone: WordPress.org Priority: normal
Severity: normal Version: 4.0
Component: Upgrade/Install Keywords:
Focuses: Cc:

Description

I've done a fresh install of WP4.0, I still see messages like so: 'WordPress 4.0 is available! Please update now.' on the WP Admin.
Additionally under 'Updates' menu I have 1 update which asks me to update EN_GB, once this is updated the messages are removed.

Should this language not be at the latest version when installed?

Change History (15)

#1 @ocean90
5 years ago

  • Keywords reporter-feedback added

I downloaded the localized package from http://en-gb.wordpress.org/ and can't the the messages, see https://cloudup.com/cBJJg7ooW_R.

Or have you choosen the language via the language chooser on install?

#2 follow-up: @ocean90
5 years ago

  • Keywords close added; reporter-feedback removed

Tested with the language chooser and I see your messages: https://cloudup.com/cJkk2SBm4At

The update message related to the translations exists, because only core translations are downloaded on install, not for themes and plugins. Click the button and you get this: https://cloudup.com/cQni4QgS4nE.

The other issue is related to #27164, #23113, #27752 and #25712 and is something I want to fix in 4.1.

#3 in reply to: ↑ 2 @jag1989
5 years ago

Replying to ocean90:

Tested with the language chooser and I see your messages: https://cloudup.com/cJkk2SBm4At

The update message related to the translations exists, because only core translations are downloaded on install, not for themes and plugins. Click the button and you get this: https://cloudup.com/cQni4QgS4nE.

The other issue is related to #27164, #23113, #27752 and #25712 and is something I want to fix in 4.1.

This is correct, Language Selected upon install. It would be better, although more timely, to install/update the locale file. It would be fantastic if this were fixed for the next minor.

#4 @ramonjosegn
5 years ago

The same problem for spanish language, always show "update" and never udpating...

#5 @m_uysl
5 years ago

Same problem for Turkish as well.

#6 @nacin
5 years ago

  • Milestone changed from Awaiting Review to 4.0.1

I have this fixed on the API side, but the code is a bit dicey, so I'm going to sleep on it and try to deploy it tomorrow.

Basically: Any locale that does not have a "complex" localized package (which is defined as having anything in /dist/ other than, at most, a readme, license, and a sample config file) will be whitelisted to be treated as essentially the same as an English package (because it is, minus translations). In this case, the install will only be told about the localized package (and thus it'll think it is up to date) and not the English package (and thus it won't complain about installing WP in English).

It's essentially making these two responses equal-ish:

While also dropping the second English offer out of the first one.

(This makes sense — it doesn't matter if you're running a localized package or just a locale, as long as there are no special modifications to the localized package.)

This will affect #29456 slightly, but instead of upgrading to the latest WP core offer of 4.0-es_ES, it'll think you're running the latest version and you'll just hit "Update Translations" to get the updated strings. (If you hit Reinstall, you'll get 4.0-es_ES which will give you the localized readme/config-sample/license, but no one should care about this.) As per above, though, if you are one of those complex locales that has /dist/ modifications or plugins that is not on the whitelist, then you will need to actually update core to 4.0-$locale, as the API will think you are only on 4.0 in English.

#7 @nacin
5 years ago

#29633 was marked as a duplicate.

#8 @SergeyBiryukov
5 years ago

#29653 was marked as a duplicate.

#9 @nacin
5 years ago

  • Owner set to nacin
  • Status changed from new to assigned

This ticket was mentioned in IRC in #wordpress-dev by SergeyBiryukov. View the logs.


5 years ago

#11 @nacin
5 years ago

  • Keywords close removed
  • Milestone changed from 4.0.1 to WordPress.org
  • Resolution set to fixed
  • Status changed from assigned to closed

This has been fixed/deployed.

#12 @ocean90
4 years ago

#27164 was marked as a duplicate.

#13 @ocean90
4 years ago

#27752 was marked as a duplicate.

#14 @ocean90
4 years ago

#27973 was marked as a duplicate.

#15 @ocean90
3 years ago

#26914 was marked as a duplicate.

Note: See TracTickets for help on using tickets.