Opened 10 years ago
Closed 10 years ago
#29529 closed defect (bug) (fixed)
Shift-click widget editing issues the Customizer
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.1 | Priority: | normal |
Severity: | normal | Version: | 4.0 |
Component: | Customize | Keywords: | has-patch |
Focuses: | ui, javascript | Cc: |
Description
Hey folks,
I like the new Customizer API which allows us to add panels to the Customizer but it's also causing a simple problem with "Shift-click to edit this widget" option.
Shift-click feature is not working on the Customizer, unless you're editing the Widgets panel.
Thanks :)
Change History (7)
#3
@
10 years ago
- Milestone changed from 4.1 to Future Release
No reason that this necessarily needs to be in 4.1, but it does depend on #28709 - we'll wait for a patch.
#4
@
10 years ago
Yeah, so once #28709 lands, as the patch exists right now, then the issue in this ticket can be resolved by first invoking (not final):
wp.customize.panel( 'widgets' ).toggle( true )
And actually, this should be automatic. So when something like this is called:
wp.customize.control( 'widget_text[123]' ).focus()
It should automatically cause the containing section and panel to also expand.
#5
@
10 years ago
- Focuses javascript added
- Keywords has-patch added
This is now fixed in the most recent patch for #28709 (now on a GitHub PR). Namely, now WidgetControl.expandControlSection()
is using the new API api.section( this.section() ).expand()
which automatically expands the containing panel if it is not expanded.
Confirmed. This is something that should be able to leverage the Customizer deep-linking functionality that westonruter is working on for 4.1 rather than all of the widgets-specific code it's currently using (which doesn't account for panels).