Opened 10 years ago
Closed 10 years ago
#29556 closed defect (bug) (fixed)
Layout bugs in "Add New" Theme section
Reported by: | jesin | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 4.1 | Priority: | normal |
Severity: | normal | Version: | 4.0 |
Component: | Themes | Keywords: | make-flow has-patch |
Focuses: | ui, administration | Cc: |
Description
- On 320px wide screens the search bar overflows and the menu above it (15, Features, Popular...) doesn't look neat.
- Under the Feature Filter section the Features division is at 33% width.
- The theme popup (that appears when a theme is clicked) has a large Install button on screens lesser than 768px.
Patch fixes the search bar by creating a new media query section for 320px and the Feature Filter.
Attachments (8)
Change History (25)
#1
@
10 years ago
- Keywords has-patch added
- Milestone changed from Awaiting Review to 4.1
- removes the theme count on small screens (>320px).
- Reverts some of the crazy of r28037
- Gives all columns an equal width. On large screens the boxes still have two columns.
- Readjusts the alignment of the install button on small screens.
A review by someone with experience writing CSS for the whole admin would be appreciated, as I'm sure I didn't catch all uses of the CSS I changed.
#4
@
10 years ago
Also reported on make/flow.
#5
@
10 years ago
That filter bar CSS is used in the media library and plugin install, if somebody would like to check. I don't believe the drawer part is used anywhere else right now, though.
#6
@
10 years ago
Tested 29556.3.diff with media library, theme install, and plugin install. Helen, would you mind double-checking it?
This would also fix the short search bar, reported in #29495.
#10
@
10 years ago
Made a minor change to 29556.3.diff, as it would still have the search bar overflow (issue 1) with screensizes just over 320px.
I also tested 29556.4.diff in media library, theme install, and plugin install.
#11
@
10 years ago
- Keywords needs-refresh added
TacoVerdo - can you make a new patch for the issues you saw? This one isn't applying.
#12
@
10 years ago
- Keywords needs-refresh removed
Patch 29556.5.diff refreshes TacoVerdo's 29556.4.diff. Patch has not been tested.
#14
follow-up:
↓ 15
@
10 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Chrome, monitor 1920 x 1080 px, search box broken in current trunk...
#15
in reply to:
↑ 14
@
10 years ago
Replying to pavelevap:
Chrome, monitor 1920 x 1080 px, search box broken in current trunk...
It happens on smaller resolutions too. Patch 29556.6.diff removes .wp-filter-search
's max-width, reverts width to 280px and sets a max-width for screens smaller than 650px.
Filters on large screen