Opened 10 years ago
Closed 9 years ago
#29571 closed enhancement (fixed)
Quicktag end tags appear after newline characters in text editor
Reported by: | JoshuaGoodwin | Owned by: | azaozz |
---|---|---|---|
Milestone: | 4.6 | Priority: | normal |
Severity: | normal | Version: | 3.9 |
Component: | Editor | Keywords: | has-patch |
Focuses: | javascript, administration | Cc: |
Description
In order to select a whole line of text in a textarea, it's often convenient to use the triple-click shortcut. In WebKit/Blink browsers, if the selected line of text is not the last line, the selection includes the newline character at the end. So when I click an editor quicktag button, the closing tag appears on the next line.
This is perhaps best illustrated with a screencast: https://mediacru.sh/d6KyDiACDuri
Instead, perhaps the closing tag should be inserted before the newline character.
I've tested on using Chrome 37 on Windows and Linux, but it's a long-standing thing.
Attachments (2)
Change History (8)
This ticket was mentioned in Slack in #core-editor by iseulde. View the logs.
9 years ago
#4
@
9 years ago
- Milestone changed from Awaiting Review to 4.6
Looks good! Thanks for the patch and apologies for the long wait.
A patch for qt.TagButton. wpLink and qt.insertContent() probably need changing too.