Twenty Twelve and Thirteen: Use proper way to get customizer settings values

[obenland]

In Twenty Thirteen we check whether the header image is removed in the Customizer JS. We do so by checking the private _wpCustomizeSettings variable.

Let's do it properly.

[nacin]

Looks like 29577.diff​ truncates html5.js.

[obenland]

The patch just served as an example for how to submit a patch in general during an "Intro to contributing to Core" session at WordCamp Los Angeles contributor day.

There should be a valid patch submitted in a few.

[kdoran]

Converted spaces to tabs

[obenland]

29577.3.diff​ is ready to go.

Patch created during WordCamp Los Angeles.

[SergeyBiryukov]

Does the same apply to _wpCustomizeSettings.values.background_color​ in Twenty Twelve?

[obenland]

Yes it does. We have to make sure to test it with 3.5 as well then.

[lancewillett]

Any updates on this one? Needs more patch? Twenty Twelve ticket and patch also needed?

[kdoran]

Replying to lancewillett:

Any updates on this one? Needs more patch? Twenty Twelve ticket and patch also needed?

I think it is good to go Lance. Sounds like Twenty Twelve may need a ticket and patch also. I'm a noob to code contribution. Is there any meaning to the ticket being changed from "New" to "Assigned"?

Kiko

[lancewillett]

If Twenty Twelve needs the change please make a new ticket and add a patch to it.

Is there any meaning to the ticket being changed from "New" to "Assigned"?

I think it usually means that someone is working on it, so it doesn't overlap with another person making a patch.

[obenland]

From Slack:

@obenland: When you have time could you review #29577 please? Need to know if Twenty Twelve also needs a similar patch. And if it's urgent for 4.1 and next theme releases in directory.

29577.4.diff​ covers Twenty Twelve as well. Just tested it successfully with 3.5.
I'm not sure we really need a separate ticket for Twenty Twelve, we could as well update the description of this ticket to make it broader, if that is the reason.

It's not necessarily urgent, but it's a reasonably small change that has been soaking for all of 4.1, so I don't see a reason to wait either.

[lancewillett]

I'll update the change at commit time to also bump the JS version numbers where they are enqueued in functions.php files.

[lancewillett]

In 30482:

Twenty Twelve and Thirteen: Use proper way to get customizer settings values.

Props obenland, kdoran. Fixes #29577.