Undefined variable: arg class-ftp.php:508

[hugodelgado]

Notice: Undefined variable: arg in wp-admin/includes/class-ftp.php on line 508. It has an easy fix:

where is:

	function nlist($pathname="") {
		return $this->_list(($arg?" ".$arg:"").($pathname?" ".$pathname:""), "NLST", "nlist");
	}

should be:

	function nlist($pathname="", arg="") {
		return $this->_list(($arg?" ".$arg:"").($pathname?" ".$pathname:""), "NLST", "nlist");
	}

[dd32]

Although this is an external library ​PemFTP it appears to be abandoned for development now, so we should probably just go ahead and make any alterations we need.

[dd32]

In 29969:

Avoid a PHP Notice in the PemFTP Library by adding a missing function parameter. This parameter is unused by WordPress.
Props hugodelgado. Fixes #29628

[dd32]

In 30310:

Always use a full filesystem path when including the FTP handler in PemFTP. This prevents other files in the includes directory being scanned/included accidentally.
See #29628

[TobiasBg]

For [30310]: __DIR__ was only added in PHP 5.3.0, so we can't use it, unfortunately.
I suggest to replace it with dirname( __FILE__ ).

[SergeyBiryukov]

[30311] missed the ticket.