Query args in paginate_links()

[obenland]

This is a follow-up to #24606.

After r28785 we parse query args from the get_pagenum_link(), but we don't pass it on to the $defaults array. Not sure if this was an oversight when it was ported over from Twenty Fourteen, or intentional.

[obenland]

Added a patch with additional UT. I'm not sure the query args need to be url-encoded. They are in Twenty Fourteen, but it looked like they are anyway, when I wrote the unit test.

Feedback on the unit test would also be greatly appreciated, not sure if it makes sense to test in that way.

[wonderboymusic]

These unit tests need to have URLs that are generated, not hardcoded

[wonderboymusic]

In 29780:

In paginate_links(), ensure that query string args are propagated to the resulting paginated links.

Adds unit tests that use DOMDocument since assertTag is being deprecated - see #29545, [29746].

Props obenland, wonderboymusic.
Fixes #29636.

[jorbin]

This unit test is continuously failing. See ​https://travis-ci.org/aaronjorbin/develop.wordpress/jobs/36779253

I'm investigating. It looks like we are setting permalink structure somewhere.

[boonebgorges]

Ha. I've been staring at this failure for the last week, and assumed it was my rig, so I ignored it.

[wonderboymusic]

yeah, I think it was your flanger pedal

[jorbin]

Above patch fixes the failure.

It stashes the permalink structure, reverts it, and then sets it back to how it was when we began.

[wonderboymusic]

[28964] and [28966] were fun - you should do that on setUp/tearDown for the whole class

[jorbin]

Makes sense. Above patch does it.

I looked into doing this for all classes, but it seems to break some other tests. I may try to revisit that in the future so our tests are better individual units.

[wonderboymusic]

In 29913:

Fix Tests_Paginate_Links tests by properly setting up / tearing down permalink structure.

Props jorbin.
Fixes #29636.

[boonebgorges]

This test is still failing. (Every other time you run it. Whee!) [29913] sets the permastruct to the value of get_option( 'permalink_structure' ), which is correct when you first run it, but wrong if you run it after the non-multisite tests are run. jorbin's .2.diff did it correctly, by setting it to .

[obenland]

r28785 introduced a bug, where encoded query arguments were decoded by parse_str() inside of wp_parse_str() but never re-encoded later on.
29636.4.diff​ encodes them again and adds UT for it.

[wonderboymusic]

In 30133:

[28785] introduced a bug, where encoded query arguments were decoded by parse_str() inside of wp_parse_str() but never re-encoded later on.

This encodes them, adds unit test.

Props obenland.
Fixes #29636.