WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#29647 closed defect (bug) (fixed)

WP_oEmbed::_strip_newlines was hooked into "oembed_dataparse", but it is private

Reported by: dikiy_forester Owned by: wonderboymusic
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.0
Component: Embeds Keywords:
Focuses: Cc:

Description

Since WP4.0 method _strip_newlines() of WP_oEmbed class is private, but it called in hook oembed_dataparse.

Change History (8)

#1 @dikiy_forester
7 years ago

  • Summary changed from WP_oEmbed::_strip_newlines was hooked into "oembed_dataparse", but is either protected or private to WP_oEmbed::_strip_newlines was hooked into "oembed_dataparse", but it is private

#2 @wonderboymusic
7 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.0.1

Looking

#3 @wonderboymusic
7 years ago

  • Keywords needs-patch removed

Indeed - thank you for catching this.

#4 @wonderboymusic
7 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 29742:

WP_oEmbed::_strip_newlines is called as a filter callback for oembed_dataparse, must be public. It was marked as private for fun in [14109] and then made private officially in [28507].

Fixes #29647 for trunk.

#5 @wonderboymusic
7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opening for 4.0.1

#6 @SergeyBiryukov
7 years ago

  • Keywords fixed-major added

#7 @nacin
7 years ago

Doesn't appear like this strictly needs to go into 4.0.1, I think.

#8 @wonderboymusic
7 years ago

  • Keywords fixed-major removed
  • Milestone changed from 4.0.1 to 4.1
  • Resolution set to fixed
  • Status changed from reopened to closed

Correct, it does not.

Note: See TracTickets for help on using tickets.