WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#29682 closed defect (bug) (fixed)

Travis CI: Remove PHP 5.6 from 'allowed to fail' section

Reported by: netweb Owned by: jorbin
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.0
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

PHP 5.6 has been released we should remove PHP 5.6 from the "allowed to fail" section of .travis.yml for Travis CI.

Attachments (1)

29682.diff (305 bytes) - added by netweb 6 years ago.

Download all attachments as: .zip

Change History (4)

@netweb
6 years ago

#1 @netweb
6 years ago

  • Keywords has-patch added

#2 @jorbin
6 years ago

  • Milestone changed from Awaiting Review to 4.1

All the tests are currently failing, so I'm hesitant to push this in yet. Once the tests are passing, it should be good to go.

#3 @jorbin
6 years ago

  • Owner set to jorbin
  • Resolution set to fixed
  • Status changed from new to closed

In 29844:

PHP 5.6 test failures shouldn't be allowed.

PHP 5.6 was released on 28 August 2014 and thus tests on it should be on the same level as all of our other PHP tests pass.

Fixes #29682
Props netweb

Note: See TracTickets for help on using tickets.