orderby for meta values is broken in 4.0

[devarni]

'orderby' => array(array('meta_key' => 'date', 'order' => 'DESC'))

is not working anymore.

[kitchin]

Did that work in a development version of 4.0? The structure to use is:

'meta_key' => 'date',
'orderby' => array('meta_value' => 'DESC'),

or the old style

'meta_key' => 'date',
'orderby' => 'meta_value',
'order' => 'DESC',

[johnbillion]

Thanks for the report, devarni, but this is indeed an invalid format. Either of kitchin's suggested formats will do the trick.

[devarni]

I think it has something to do with the meta_query... this breaks the order for unknown reasons in combination with the OR relation. This behavior is new with 4.0. Removing the meta_query ordering is working as expected.

This is the example query:
If the meta key "is_private" or does not exist or if the value is empty the post should be queried.
This is not working with 4.0 anymore and the same time the orderby is not working correctly.

$query_vars = array(
            'post_type' => DG_POST_SLUG,
            'meta_key' => DG_PREFIX . 'date',
            'orderby'  => array('meta_value_num' => 'DESC'),
            'posts_per_page' => $posts_per_page,
            'paged' => $page_no,
            'meta_query' => array(
                'relation' => 'OR',
                array(
                    'key' => DG_PREFIX . 'is_private',
                    'compare' => 'NOT EXISTS',
                ),
                array(
                    'key' => DG_PREFIX . 'is_private',
                    'value' => '',
                    'type' => 'CHAR',
                    'compare' => '='
                )
            ),
        );

[kitchin]

That's different. What was your query in 3.9 ?

[devarni]

Replying to kitchin:

That's different. What was your query in 3.9 ?

It was the same query in 3.9
Besides the ordering thing, the OR relation is not working in 4.0 and the private records are returned!

[kitchin]

But 'orderby' was not an array in 3.9. Was that the query you had in 3.9? It's easier if you paste in the old query than describe it.